Fixed vertical scrolling in tables of Audit Logs and Asset Readings (Issue-22) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-garg
previously requested changes
Dec 20, 2017
| @@ -0,0 +1,9 @@ | |||
| table.scroll { | |||
There was a problem hiding this comment.
I'm more concerned about responsiveness; why a tablet and 27" monitor should have same height for scrollable container; we should make it conditional per viewport
praveen-garg
dismissed
their stale review
3183df0 is in with latest changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed vertical scrolling in tables of Audit Logs and Asset Readings (Issue-22)