Grant ec2:DescribeSnapshots to the murmur read-only role [murmur:murmuration/fix-image-storage-oversize-billing] - #5
Open
chenruichou wants to merge 1 commit into
Conversation
murmur bills a tenant's baked AMIs on what EBS actually stores, which lives on the AMI's snapshots: DescribeImages reports only each block mapping's nominal volume size, and billing that over-charges ~8× since a snapshot stores only the blocks written to its source volume. Reading FullSnapshotSizeInBytes takes ec2:DescribeSnapshots on the read-only role this module provisions. Companion to the murmuration change that switches image-storage accounting to the stored size.
ApprovabilityVerdict: Needs human review While the change is technically minimal (adding one read-only IAM permission), its stated purpose is to enable image-storage accounting/billing functionality. Changes that affect billing or metering logic warrant human review. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to prassoai/murmuration#5106, which fixes a ~8× over-charge in baked-image storage billing.
murmur billed a tenant's baked images on their nominal disk size. Both clouds bill what they actually store. For an AMI that quantity lives on its EBS snapshots —
DescribeImagesreports only each block mapping's nominal volume size, and a snapshot stores only the blocks written to its source volume — so murmur now readsFullSnapshotSizeInBytesviaDescribeSnapshots.That takes
ec2:DescribeSnapshotson the read-only role this module provisions. Without it, a customer-managed AWS placement's image listing fails with an error naming the missing permission (murmur fails loudly rather than billing a number nobody vouched for). Apply this before the murmuration change rolls out.Read-only, unconditioned, alongside the existing
ec2:Describe*grants — no new blast radius.Created via Murmur
🤖 Generated with Claude Code
Note
Grant
ec2:DescribeSnapshotsto the murmur read-only IAM roleAdds
ec2:DescribeSnapshotsto thereadonly_ec2IAM policy in main.tf. This permission is needed to account for AMI storage billing, which is based on snapshot sizes rather than image metadata alone.Macroscope summarized 7540a61.
🐞