Skip to content

docs: view-as-customer Phase 0 design review [murmur:back/view-as-customer-phase0-review]#27

Open
clairerosenfeld wants to merge 1 commit into
mainfrom
murmur/w/back/github_oauth/clairerosenfeld/view-as-customer-phase0-review
Open

docs: view-as-customer Phase 0 design review [murmur:back/view-as-customer-phase0-review]#27
clairerosenfeld wants to merge 1 commit into
mainfrom
murmur/w/back/github_oauth/clairerosenfeld/view-as-customer-phase0-review

Conversation

@clairerosenfeld

@clairerosenfeld clairerosenfeld commented May 15, 2026

Copy link
Copy Markdown

Summary

  • Design review of prassoai/back#10951 — View-as-Customer Phase 0 for adminscope
  • Spun up the full local stack (make up auth adminscope), navigated to the new route, and took real screenshots
  • Posted detailed design review comment with findings and sidebar placement proposal

Screenshots

Before (no customer view route existed):
The customer detail sidebar had no "Customer View" entry. Admins had to cross-reference Clickety Clack, Areas, and Repos pages to reconstruct what the customer sees.

After — Landing view with TV-bezel frame + HomeMirror:
Landing

After — Investigation panel with sprint data table:
Investigation

After — RPC response viewer expanded:
RPC viewer

Review findings

  • TV-bezel frame works — clean visual separation, not gimmicky
  • InvestigationPanel is value-add (sprint metadata banner is the single most useful debug info for CS)
  • RPC viewers are a good escape hatch; higher-signal alternatives (rolled-up summary, anomaly highlighting) suggested for Phase 1
  • Sidebar placement at top of nav is correct; minor suggestion to merge into Overview section to reduce redundancy
  • Code quality is solid — follows adminscope conventions, extracted shared utils, proper loading/empty states
  • Error handling gap — failed RPCs show loading skeletons indefinitely; needs error fallback UI

Full review: https://github.com/prassoai/back/pull/10951#issuecomment-4463794349

Test plan

  • Stack started with make up auth adminscope
  • Navigated to /customers/github_organization/139157646/view
  • Verified HomeMirror renders with live data (Top Contributors, Coding Time, Area Focus)
  • Verified Investigation panel shows sprint metadata and eng-effort table
  • Verified RPC response viewers expand/collapse with real JSON
  • Verified sidebar shows "Customer View" with Eye icon at top of nav
  • Screenshots taken of all sections

🤖 Generated with Claude Code

Agent dashboard: https://cloud.murmur.dev/github_app/prassoai/task/github_app%2Fprassoai%2Fw%2Fback%2Fgithub_oauth%2Fclairerosenfeld%2Fview-as-customer-phase0-review

Note

Add design review notes for View-as-Customer Phase 0

Adds review-notes.md documenting the Phase 0 design review for the View-as-Customer feature, including a reference to a specific GitHub PR comment and a note pointing to screenshots stored under docs/screenshots/view-as-customer-phase0-review/.

Macroscope summarized fd8ffee.

🐞

Summarization
Workflow

Review of prassoai/back#10951 with screenshots and sidebar placement analysis.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant