Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data dir explanation #16

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Add data dir explanation #16

merged 4 commits into from
Jun 7, 2024

Conversation

prakaa
Copy link
Owner

@prakaa prakaa commented Jun 6, 2024

How's this @mdavis-xyz?

Closes #12

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (bbcedc2) to head (aa44d4d).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   81.98%   81.81%   -0.17%     
==========================================
  Files           2        2              
  Lines         161      165       +4     
  Branches       26       28       +2     
==========================================
+ Hits          132      135       +3     
- Misses         26       27       +1     
  Partials        3        3              
Flag Coverage Δ
unittests 81.81% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdavis-xyz
Copy link
Contributor

It's still not clear to me. DATA contains PREDISPATCH* and P5MIN* files. So if you want those files, how do you choose which folder to use?

@prakaa
Copy link
Owner Author

prakaa commented Jun 7, 2024

It's still not clear to me. DATA contains PREDISPATCH* and P5MIN* files. So if you want those files, how do you choose which folder to use?

Yeah fair. I initially thought users who might want to access this data would use NEMSEER so I didn't bother to explain. But I think it's worth including if these are options in this package (which I think they should be).

Hopefully what's there is clear enough now. Thanks for your feedback!

@prakaa prakaa merged commit 3e60e87 into master Jun 7, 2024
14 checks passed
@prakaa prakaa deleted the data_dir branch June 7, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify data_dir options
3 participants