Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Models, Hooks #406

Merged
merged 6 commits into from
Aug 13, 2023
Merged

Refactor Models, Hooks #406

merged 6 commits into from
Aug 13, 2023

Conversation

prabhuignoto
Copy link
Owner

@prabhuignoto prabhuignoto commented Aug 12, 2023 •
edited
Loading

Description

  • Adding additional unit test cases
  • Refactoring existing typescript models and added detailed comments
  • Refactored custom react hooks

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@vercel
Copy link

vercel bot commented Aug 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chrono-uc7v ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2023 0:17am

@github-actions
Copy link

github-actions bot commented Aug 12, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/react-chrono.js 31.66 KB (-0.02% 🔽) 634 ms (-0.02% 🔽) 112 ms (+31.42% 🔺) 745 ms
dist/react-chrono.esm.js 31.74 KB (-0.03% 🔽) 635 ms (-0.03% 🔽) 88 ms (+25.21% 🔺) 723 ms
dist/react-chrono.umd.js 33.47 KB (-0.02% 🔽) 670 ms (-0.02% 🔽) 92 ms (+103.98% 🔺) 761 ms

@prabhuignoto prabhuignoto changed the title Refactor_models Refactor Models Aug 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prabhuignoto prabhuignoto merged commit 46c8028 into master Aug 13, 2023
11 checks passed
@kodiakhq kodiakhq bot deleted the refactor_models branch August 13, 2023 12:52
@prabhuignoto prabhuignoto changed the title Refactor Models Refactor Models, Hooks Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prabhuignoto