fix sonar security issue (#458)

replacing Math.random with custom getUniqueId function
prabhuignoto · Jan 17, 2024 · d51984a · d51984a · vercel · Jan 17, 2024
1 parent c353fce
commit d51984a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/sonar-project.properties b/sonar-project.properties
@@ -6,7 +6,7 @@ sonar.organization=prabhuignoto
 #sonar.projectVersion=1.0
 
 sonar.sources=src
-sonar.exclusions=**/node_modules/**,**/*.test.js,**/*.spec.js,**/*.test.jsx,**/*.spec.jsx,**/*.test.ts,**/*.spec.ts,**/*.test.tsx,**/*.spec.tsx,coverage/**,build/**,dist/**,public/**,src/setupTests.js,src/setupTests.ts,src/setupTests.tsx,src/setupTests.jsx,src/setupTests.test.js,src/setupTests.test.ts,src/setupTests.test.tsx,src/setupTests.test.jsx,src/setupTests.spec.js,src/setupTests.spec.ts,src/setupTests.spec.tsx,src/setupTests.spec.jsx,src/serviceWorker.js,src/serviceWorker.ts,src/serviceWorker.tsx,src/serviceWorker.jsx,src/serviceWorker.test.js,src/serviceWorker.test.ts,src/serviceWorker.test.tsx,src/serviceWorker.test.jsx,src/serviceWorker.spec.js,src/serviceWorker.spec.ts,src/serviceWorker.spec.tsx,src/serviceWorker.spec.jsx,demo/**
+sonar.exclusions=**/node_modules/**,**/*.test.js,**/*.spec.js,**/*.test.jsx,**/*.spec.jsx,**/*.test.ts,**/*.spec.ts,**/*.test.tsx,**/*.spec.tsx,coverage/**,build/**,dist/**,public/**,src/setupTests.js,src/setupTests.ts,src/setupTests.tsx,src/setupTests.jsx,src/setupTests.test.js,src/setupTests.test.ts,src/setupTests.test.tsx,src/setupTests.test.jsx,src/setupTests.spec.js,src/setupTests.spec.ts,src/setupTests.spec.tsx,src/setupTests.spec.jsx,src/serviceWorker.js,src/serviceWorker.ts,src/serviceWorker.tsx,src/serviceWorker.jsx,src/serviceWorker.test.js,src/serviceWorker.test.ts,src/serviceWorker.test.tsx,src/serviceWorker.test.jsx,src/serviceWorker.spec.js,src/serviceWorker.spec.ts,src/serviceWorker.spec.tsx,src/serviceWorker.spec.jsx,src/demo/**
 
 
 # Path is relative to the sonar-project.properties file. Replace "\" by "/" on Windows.

diff --git a/src/components/index.tsx b/src/components/index.tsx
@@ -61,7 +61,7 @@ const Chrono: React.FunctionComponent<Partial<TimelineProps>> = (
 
     return Array.from({ length: itemLength }).map((_, index) => ({
       active: index === activeItemIndex,
-      id: Math.random().toString(16).slice(2),
+      id: getUniqueID(),
       visible: true,
     }));
   };
@@ -73,7 +73,6 @@ const Chrono: React.FunctionComponent<Partial<TimelineProps>> = (
       return lineItems.map((item, index) => ({
         ...item,
         active: index === pos,
-        // id: Math.random().toString(16).slice(2),
         visible: true,
       }));
     } else {