Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two issues encountered in Edge browser (#507) #508

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix two issues encountered in Edge browser (#507) #508

wants to merge 2 commits into from

Commits on May 26, 2020

  1. * Use !isFile() instead of !(state.file instanceof Blob) when det… 

    …ermining if a file has loaded, since in my testing, Edge is presenting a `File` object at this stage, rather than the `Blob` that Chrome etc are presenting (fixes pqina#507).

* If `createFileProcessorFunction` is presented with a file object that is not of type `Blob` (such as `File`, as seen in Edge browser), it attempts to iterate over it using `forEach` as if it were an iterable object, however `File` objects do not have a `forEach` method. Resolve this by treating all file object input into this function as though they are a singular, non-iterable object (fixes pqina#507).

* Fix comment typo.
    @dannya
    dannya committed May 26, 2020
    Configuration menu
    Copy the full SHA
    2401d02 View commit details
    Browse the repository at this point in the history

  2. * Remove console.log (which looks like it was left in accidentally, s… 

    …ince there are no other console.log statements in the project!)
    @dannya
    dannya committed May 26, 2020
    Configuration menu
    Copy the full SHA
    9c6a1e9 View commit details
    Browse the repository at this point in the history