Open
Conversation
…lled locally I ran into thie use-case when trying to find a map that I had played before, but did not have installed. To support this, we're using the existing `BeatmapManager.IsAvailableLocally` to filter the API response. It's possible for this to cause a page to be empty after the filter is applied, so we also try to catch that case and "auto-fetch" the next page when necessary.
peppy
reviewed
Feb 23, 2026
osu.Game/Overlays/BeatmapListing/BeatmapListingSearchControl.cs
Outdated
Show resolved
Hide resolved
Member
|
Please also read through #15727 which contains some commentary from me regarding this implementation. |
Author
|
Thanks for the review and comments. I think I've addressed them all. After reading the issue you linked, I understand that the concern with the implementation of this is that there's no bounding on the fetching, since we continue until cursor exhaustion. Potentially this could lead to way too many requests to the API. We could:
Let me know if you think that's a good approach and if you have thoughts on what the cap should be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this use-case when trying to find a map that I had played before but did not have installed.
I've added a couple unit tests to support the feature I implemented.
Closes #15727