-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redesigned beatmap wedge for new song select #32480
Conversation
Reduces animation clutter.
There's quite a bit of movement in the fill flow line with play counts. I think it would help to pad each one so they (in the majority case) don't change position. |
What about making the length and BPM right-aligned? Another thing I thought about is what if you could click the heart icon (or whole UI element) of the favorite count to favorite the beatmapset? And when it's favorited, the heart appears in pink. Overall the design looks really cool. |
Right-side alignment won't work well for BPM since it's length is variable, also generally aligning anything on the right side on the wedge itself probably won't look good. |
Added minimum padding to statistics as per suggestion. videoCleanShot.2025-03-21.at.08.56.55.mp4 |
The width is based on the statistic label so it doesn't accumulate too much space to the left, giving hit count statistics a breathing space.
I don't follow this part, it's not like the statistics move around when switching between beatmaps, what's hard to compare here? |
Agree they should all be the same width. I'm also not sure about the colour of the bars changing with the SR. Something about it is perturbing to me – it's updating dynamically but not with the thing it's representing. Doesn't need to be changed immediately, but I think it may work better being coloured (or at least lightened) in line with the local number it's representing. |
Padding = new MarginPadding { Left = 10f }, | ||
Children = new[] | ||
{ | ||
firstStatisticDifficulty = new WedgeStatisticDifficulty(BeatmapsetsStrings.ShowStatsCs) { Width = 65 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixed width doesn't work for other languages. The statistic can probably be autosized x, and the bar fixed to 65. I think it looks fine if the text is exceeds the bar (right now in english, the approach rate text is 70 and exceeds it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted that in some form in 6ca3685, now all statistics accumulate a width enough for the longest label across them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I'm not really fond of this extreme case (one long translation and all others are wide):
I'm not sure that can be improved besides adding some spacing between the count and difficulty statistics, unless you have any bright ideas I'm not interested in dissecting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would this look if a statistic in the middle has a longer label than everything else, the bars will no longer be equally spaced and it'll look awkward in my eyes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happens on beatmap difficulty attributes.
Closing this PR as un-reviewable due to chained PRs with unclear dependencies. For changes of this size, it's nigh impossible to review on a per-PR basis. Some PRs in the sequence are very unclear on why they "depend" on the previous PR. There are hundreds of commits but individual commits are not meaningful. #32673 -> #32480 -> #32496 -> #32533 -> #32715 will (attempt) review of #32715 alone |
766b745
to
4abb672
Compare
Design reference: https://www.figma.com/design/GjPIkoh2kvt7hSLrqeinTQ/Client%2FSong-Select?node-id=6484-8213&t=GdkHN5mAyNgP0sdX-4
Preview:
CleanShot.2025-03-20.at.13.10.29.mp4
Follow-up tasks:
BeatmapSetLookupCache
class to cache online beatmap attributes such as play & favourites count