Fix calculation of total_length being inconsistent with old submission
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare https://github.com/peppy/osu-web-10/blob/18ae5b4f9dc6e9637d69e47460e6affb5840d3ef/www/web/osu-osz2-bmsubmit-upload.php#L151. Note that `Math.Ceiling()` is chosen intentionally rather than `Math.Floor()`. The reason for this is that web-10 flooring is technically incorrect if we are to assume editor timestamps are validated against `total_length` because you could have a timestamp that's just a couple of milliseconds past the floored-time-of-last-object. Reported in https://discord.com/channels/90072389919997952/1259818301517725707/1436493355520626690.
smoogipoo
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare web-10.
This is more important to get right than I originally thought because this isn't just a value for show, it's actually used to validate timestamps in mod posts apparently.
Note that
Math.Ceiling()is chosen intentionally rather thanMath.Floor(). The reason for this is that web-10 flooring is technically incorrect if we are to assume editor timestamps are validated againsttotal_lengthbecause you could have a timestamp that's just a couple of milliseconds past the floored-time-of-last-object.Reported in https://discord.com/channels/90072389919997952/1259818301517725707/1436493355520626690 / https://osu.ppy.sh/beatmapsets/2455343/discussion/-/generalAll#/5254737.