Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Solo] attributes getting committed by blocking from NUnit runs #6522

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

peppy
Copy link
Member

@peppy peppy commented Feb 7, 2025

See peppy/osu@aa329f3

Arguably this impairs the ability to leave them specified locally while running headless tests, but I don't think this is a blocker.

Arguably this impairs the ability to leave them specified locally while
running headless tests, but I don't think this is a blocker.
@bdach bdach self-requested a review February 7, 2025 07:47
bdach
bdach previously approved these changes Feb 7, 2025
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly reasonable

osu.Framework/Testing/TestScene.cs Outdated Show resolved Hide resolved
@bdach bdach enabled auto-merge February 7, 2025 08:10
@bdach bdach merged commit 62b98aa into ppy:master Feb 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants