Support dangling line action in Operator Strategies #939
Conversation
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
|
|
| } | ||
|
|
||
| void addLoadReactivePowerAction(const JavaHandle& analysisContext, const std::string& actionId, const std::string& loadId, bool relativeValue, double reactivePower) { | ||
| PowsyblCaller::get()->callJava(::addLoadReactivePowerAction, analysisContext, (char*) actionId.data(), (char*) loadId.data(), relativeValue, reactivePower); |
There was a problem hiding this comment.
can you add the new dangling line new actions in the documentation? The list of supported actions is in the file /docs/user_guide/security.rst (section Operator strategies and remedial actions)
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Signed-off-by: Naledi <[email protected]>
docs/user_guide/security.rst
Outdated
|
|
||
| The next example defines two different kinds of actions, which can be set with the `add_dangling_line_reactive_power_action` method, | ||
| and the `add_dangling_line_reactive_power_action`. | ||
|
|
||
| .. doctest:: | ||
| :options: +NORMALIZE_WHITESPACE | ||
|
|
||
| >>> n = pp.network.create_eurostag_tutorial_example1_with_tie_lines_and_areas() | ||
| >>> sa = pp.security.create_analysis() | ||
| >>> sa.add_dangling_line_active_power_action('id', 'NHV1_XNODE1', False, 5.0 ) | ||
| >>> sa.add_dangling_line_reactive_power_action('id', 'NHV1_XNODE1', True, 2.0 ) | ||
|
|
There was a problem hiding this comment.
I think the idea for the doc was to only add two line in the bloc between lines 108 and 115 to reference the new types of action
We also only recently realized that, in order to see in the doc the docstring information of python methods, we actually need to add lines to the files in docs/reference (in this case, docs/reference/security.rst, after line 69). Could you please add the missing methods of SecurityAnalysis.add_..._action to this file ?
Signed-off-by: Naledi EL CHEIKH <[email protected]>
|
|
|
Waiting for powsybl/powsybl-open-loadflow#1102 to be merged (-> release train of september) |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #863
Does this PR introduce a breaking change or deprecate an API?