Asym parser

src/main/java/com/powsybl/openloadflow/ac/equations/asym/AbstractAsymmetricalClosedBranchCoupledFlowEquationTerm.java

@@ -186,7 +186,7 @@ protected static SequenceType getSequenceType(Variable<AcVariableType> variable)
             case BUS_V, BUS_PHI -> SequenceType.POSITIVE;
             case BUS_V_NEGATIVE, BUS_PHI_NEGATIVE -> SequenceType.NEGATIVE;
             case BUS_V_ZERO, BUS_PHI_ZERO -> SequenceType.ZERO;
-            default -> throw new IllegalStateException("Unknown variable: " + variable);
+            default -> throw new IllegalStateException(UNKNOWN_VAR + variable);
         };
     }
 

src/main/java/com/powsybl/openloadflow/ac/nr/NewtonRaphson.java

@@ -108,12 +108,12 @@ public void reportAndLogLargestMismatchByAcEquationType(Reporter reporter, Equat
     }
 
     private String getEquationTypeDescription(AcEquationType acEquationType) {
-        switch (acEquationType) {
-            case BUS_TARGET_P: return "TargetP";
-            case BUS_TARGET_Q: return "TargetQ";
-            case BUS_TARGET_V: return "TargetV";
-            default: return null; // not implemented for other ac equation types
-        }
+        return switch (acEquationType) {
+            case BUS_TARGET_P -> "TargetP";
+            case BUS_TARGET_Q -> "TargetQ";
+            case BUS_TARGET_V -> "TargetV";
+            default -> null; // not implemented for other ac equation types
+        };
     }
 
     private NewtonRaphsonStatus runIteration(StateVectorScaling svScaling, MutableInt iterations, Reporter reporter) {
@@ -203,8 +203,8 @@ public static void initStateVector(LfNetwork network, EquationSystem<AcVariableT
                     x[v.getRow()] = network.getBranch(v.getElementNum()).getPiModel().getR1();
                     break;
 
-                case DUMMY_P:
-                case DUMMY_Q:
+                case DUMMY_P,
+                        DUMMY_Q:
                     x[v.getRow()] = 0;
                     break;
 
@@ -290,8 +290,8 @@ public void updateNetwork() {
                     network.getBranch(v.getElementNum()).getPiModel().setR1(stateVector.get(v.getRow()));
                     break;
 
-                case DUMMY_P:
-                case DUMMY_Q:
+                case DUMMY_P,
+                     DUMMY_Q:
                     // nothing to do
                     break;
 
@@ -330,6 +330,7 @@ public NewtonRaphsonResult run(VoltageInitializer voltageInitializer, Reporter r
         Vectors.minus(equationVector.getArray(), targetVector.getArray());
 
         NewtonRaphsonStoppingCriteria.TestResult initialTestResult = parameters.getStoppingCriteria().test(equationVector.getArray(), equationSystem);
+        //StateVectorScaling svScaling = StateVectorScaling.fromMode(parameters.getStateVectorScalingMode(), initialTestResult);
         StateVectorScaling svScaling = StateVectorScaling.fromMode(parameters, initialTestResult);
 
         LOGGER.debug("|f(x0)|={}", initialTestResult.getNorm());

src/main/java/com/powsybl/openloadflow/network/extensions/iidm/AsymmetricalBranchConnector.java

@@ -54,4 +54,24 @@ public boolean isFortescueRepresentation() {
     public boolean isPositiveSequenceAsCurrent() {
         return isPositiveSequenceAsCurrent;
     }
+
+    public void setPositiveSequenceAsCurrent(boolean positiveSequenceAsCurrent) {
+        isPositiveSequenceAsCurrent = positiveSequenceAsCurrent;
+    }
+
+    public void setFortescueRepresentation(boolean fortescueRepresentation) {
+        isFortescueRepresentation = fortescueRepresentation;
+    }
+
+    public void setHasPhaseA(boolean hasPhaseA) {
+        this.hasPhaseA = hasPhaseA;
+    }
+
+    public void setHasPhaseB(boolean hasPhaseB) {
+        this.hasPhaseB = hasPhaseB;
+    }
+
+    public void setHasPhaseC(boolean hasPhaseC) {
+        this.hasPhaseC = hasPhaseC;
+    }
 }

src/main/java/com/powsybl/openloadflow/network/extensions/iidm/LineAsymmetrical.java

@@ -74,6 +74,10 @@ public void setAsymConnectorBus2(AsymmetricalBranchConnector asymConnectorBus2)
         this.asymConnectorBus2 = asymConnectorBus2;
     }
 
+    public void setAsymConnectorBus1(AsymmetricalBranchConnector asymConnectorBus1) {
+        this.asymConnectorBus1 = asymConnectorBus1;
+    }
+
     public static ComplexMatrix getAdmittanceMatrixFromImpedanceAndBmatrix(ComplexMatrix zabc, ComplexMatrix babc, boolean hasPhaseA, boolean hasPhaseB, boolean hasPhaseC, double length) {
 
         // The lines are sometimes specified as impedance and susceptance matrices.

src/main/java/com/powsybl/openloadflow/network/impl/LfBranchImpl.java

@@ -216,9 +216,15 @@ private static void createTransfoToAsym(TwoWindingsTransformer t2w, double zb, L
 
                 if (asymBus1 != null) {
                     side1VariableType = asymBus1.getAsymBusVariableType();
+                    if (!asymBus1.isFortescueRepresentation()) {
+                        throw new PowsyblException("A three phase transformer must have its busses in Fortescue representation but bus 1 of  '" + t2w.getId() + "' is in ABC representation");
+                    }
                 }
                 if (asymBus2 != null) {
                     side2VariableType = asymBus2.getAsymBusVariableType();
+                    if (!asymBus2.isFortescueRepresentation()) {
+                        throw new PowsyblException("A three phase transformer must have its busses in Fortescue representation but bus 2 of  '" + t2w.getId() + "' is in ABC representation");
+                    }
                 }
 
                 AsymThreePhaseTransfo asym3phaseTfo = new AsymThreePhaseTransfo(leg1Type, leg2Type, stepLegConnectionType,