Support of asymmetrical transformer #806

JB-H · 2023-06-27T20:23:31Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
[x ] Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

New feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
Takes into account transformers and missing phases in asym load flow

Does this PR introduce a breaking change or deprecate an API?

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: JB-H <[email protected]>

implementation of 34 node feeder grid test Signed-off-by: JB-H <[email protected]>

Signed-off-by: JB-H <[email protected]>

test Signed-off-by: JB-H <[email protected]>

Signed-off-by: JB-H <[email protected]>

sonarqubecloud · 2023-10-12T17:07:12Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
43 Code Smells

89.7% Coverage
0.5% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

# Conflicts: # src/main/java/com/powsybl/openloadflow/ac/equations/asym/AbstractAsymmetricalClosedBranchCoupledFlowEquationTerm.java # src/main/java/com/powsybl/openloadflow/ac/equations/asym/AsymmetricalAcEquationSystemCreator.java # src/main/java/com/powsybl/openloadflow/ac/equations/asym/AsymmetricalClosedBranchCoupledCurrentEquationTerm.java # src/main/java/com/powsybl/openloadflow/ac/equations/asym/AsymmetricalClosedBranchCoupledPowerEquationTerm.java # src/main/java/com/powsybl/openloadflow/ac/solver/NewtonRaphson.java

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

# Conflicts: # src/main/java/com/powsybl/openloadflow/ac/equations/asym/AsymmetricalAcEquationSystemCreator.java

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

sonarqubecloud · 2023-12-09T21:58:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
48 Code Smells

90.0% Coverage
0.2% Duplication

annetill · 2024-05-03T13:10:27Z

src/main/java/com/powsybl/openloadflow/util/ComplexMatrix.java

+/**
+ * @author Jean-Baptiste Heyberger <jbheyberger at gmail.com>
+ */
+public class ComplexMatrix {


Can we imagine having this class in powsybl-core? There is a lot of small code parts using complex all over Powsybl. @zamarrenolm could be interested here.

Done with powsybl/powsybl-core#2835, be careful about -1 indexing change.

PR is merged, rework needed later.

annetill · 2024-05-03T13:11:52Z

src/main/java/com/powsybl/openloadflow/util/Fortescue.java

@@ -9,6 +9,8 @@
 package com.powsybl.openloadflow.util;

 import com.powsybl.math.matrix.DenseMatrix;
+import net.jafama.FastMath;
+import org.apache.commons.math3.complex.Complex;


Same remark, I wonder if it is the good place for this class.

Reminder: use FortescueUtil in core.

annetill · 2024-05-07T08:15:22Z

src/main/java/com/powsybl/openloadflow/network/extensions/LegConnectionType.java

+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+package com.powsybl.openloadflow.network.extensions;


Use WindingConnectionType from powsybl-core instead.

annetill · 2024-05-07T08:20:29Z

src/main/java/com/powsybl/openloadflow/network/extensions/AsymTransfo2W.java

+/**
+ * @author Jean-Baptiste Heyberger <jbheyberger at gmail.com>
+ */
+public class AsymTransfo2W {


Why this new extension compared to existing TwoWindingsTransformerFortescue? I see that you prefer using z here than r and x already present in the extension.

annetill · 2024-05-07T09:28:49Z

src/main/java/com/powsybl/openloadflow/network/extensions/iidm/LoadType.java

+/**
+ * @author Jean-Baptiste Heyberger <jbheyberger at gmail.com>
+ */
+public enum LoadType {


Try to use the load model zip instead.

annetill · 2024-05-07T09:52:30Z

src/main/java/com/powsybl/openloadflow/network/extensions/iidm/AsymmetricalBranchConnector.java

+/**
+ * @author Jean-Baptiste Heyberger <jbheyberger at gmail.com>
+ */
+public class AsymmetricalBranchConnector {


I think this object is not mature enough to go in powsybl-core. The extension LineAsymmetrical should stay here too because it depends on this connector.

How do you know the type of a bus "wye" or "delta?
Then, it is unexpected that isPositiveSequenceAsCurrent is an input data. Same remark for isFortescueRepresentation.

# Conflicts: # src/main/java/com/powsybl/openloadflow/ac/equations/AbstractClosedBranchAcFlowEquationTerm.java # src/main/java/com/powsybl/openloadflow/ac/equations/asym/AsymmetricalAcEquationSystemCreator.java # src/main/java/com/powsybl/openloadflow/ac/solver/NewtonRaphson.java # src/main/java/com/powsybl/openloadflow/network/impl/LfBusImpl.java

Signed-off-by: Anne Tilloy <[email protected]>

sonarqubecloud · 2024-05-07T13:47:25Z

Quality Gate passed

Issues
44 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

annetill · 2024-05-10T06:46:58Z

src/main/java/com/powsybl/openloadflow/network/extensions/iidm/Tfo3Phases.java

+    private Boolean isOpenPhaseC2;
+
+    // in case of a Delta-Wye or Wye-Delta connexion,
+    // this attribute informs if this is a forward (step-up) or backward (step-down) connexion


Do you have some documentation about this attribute? I know what is a step-up transformer and a step-down transformer, but I am not sure it is what we mean here.

annetill · 2024-05-10T06:49:54Z

src/main/java/com/powsybl/openloadflow/network/extensions/iidm/LineAsymmetrical.java

+
+    public static final String NAME = "lineAsymmetrical";
+
+    private ComplexMatrix yabc; // a three phase admittance matrix can be provided in input and will be used as first option if not null


And what is the second option?

asymTfo Implementation 13 nodes Test

24f6623

Signed-off-by: JB-H <[email protected]>

JB-H requested review from geofjamg and annetill June 27, 2023 20:23

JB-H added 27 commits June 28, 2023 00:03

use of LfAsymBus class

f82146e

Signed-off-by: JB-H <[email protected]>

use of LfAsymLine class

ac1bea1

Signed-off-by: JB-H <[email protected]>

removal of duplicated test

4c4f2f4

Signed-off-by: JB-H <[email protected]>

update of 13 bus feeder test

ca51e62

Signed-off-by: JB-H <[email protected]>

implementation of multiple loads at bus

e638feb

implementation of 34 node feeder grid test Signed-off-by: JB-H <[email protected]>

Merge remote-tracking branch 'origin/AsymTfoImpl' into AsymTfoImpl

81763b1

use of iidm LoadAsymmetrical extension

eac7ab2

Signed-off-by: JB-H <[email protected]>

Merge remote-tracking branch 'origin/AsymTfoImpl' into AsymTfoImpl

05a20c1

use of iidm LineFortescue extension

693fd0b

Signed-off-by: JB-H <[email protected]>

refactoring path

68850da

Signed-off-by: JB-H <[email protected]>

tests refactoring

4eea4c9

Signed-off-by: JB-H <[email protected]>

Merge remote-tracking branch 'origin/AsymTfoImpl' into AsymTfoImpl

ab0fb5f

tests refactoring 2

30c4168

Signed-off-by: JB-H <[email protected]>

refactoring 3

ec8cdd6

Signed-off-by: JB-H <[email protected]>

refactoring 4

764dff8

Signed-off-by: JB-H <[email protected]>

refactoring 5

fbcb759

Signed-off-by: JB-H <[email protected]>

refactoring 6

e6e2e1a

Signed-off-by: JB-H <[email protected]>

refactoring 7

9b92575

test Signed-off-by: JB-H <[email protected]>

refactoring 8

0df7346

test Signed-off-by: JB-H <[email protected]>

refactoring 9

b49e358

test Signed-off-by: JB-H <[email protected]>

refactoring 10

292c6ca

test Signed-off-by: JB-H <[email protected]>

refactoring 10

bda2c14

test Signed-off-by: JB-H <[email protected]>

refactoring 11 et test coverage

19e78af

Signed-off-by: JB-H <[email protected]>

refactoring 12 et test coverage

f7e05cc

Signed-off-by: JB-H <[email protected]>

refactoring 13

342dc7a

Signed-off-by: JB-H <[email protected]>

refactoring 14

d107a08

Signed-off-by: JB-H <[email protected]>

refactoring 15

1ac282e

Signed-off-by: JB-H <[email protected]>

JB-H added 4 commits October 10, 2023 22:28

removal of load extension2 replaced by use of ZIP model

0d8d9e1

Signed-off-by: JB-H <[email protected]>

corrections on delta transformers

ccc77c6

Signed-off-by: JB-H <[email protected]>

complex matrix refacto

59eccb8

Signed-off-by: JB-H <[email protected]>

Asymm Bus extension refactoring

577d04a

Signed-off-by: JB-H <[email protected]>

geofjamg added 10 commits November 29, 2023 20:14

Merge

acb16c8

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

6357e9e

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

01675e6

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

bb118c4

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

99aff47

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Merge branch 'main' into AsymTfoImpl

7ed488e

# Conflicts: # src/main/java/com/powsybl/openloadflow/ac/equations/asym/AsymmetricalAcEquationSystemCreator.java

Wip

cba3933

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

3cb2e63

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

a0d56ea

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

annetill reviewed May 3, 2024

View reviewed changes

annetill reviewed May 7, 2024

View reviewed changes

annetill added 2 commits May 7, 2024 13:10

Merge.

b3764c7

Signed-off-by: Anne Tilloy <[email protected]>

annetill changed the title ~~asymTfo Implementation 13 nodes Test~~ Support of asymmetrical transformer May 7, 2024

Clean.

daed2dd

Signed-off-by: Anne Tilloy <[email protected]>

annetill reviewed May 10, 2024

View reviewed changes

annetill mentioned this pull request May 10, 2024

[Draft] Asymmetrical line and two windings transformer extensions powsybl/powsybl-core#3004

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support of asymmetrical transformer #806

Support of asymmetrical transformer #806

JB-H commented Jun 27, 2023

sonarqubecloud bot commented Oct 12, 2023

sonarqubecloud bot commented Dec 9, 2023

annetill May 3, 2024

annetill May 6, 2024 •

edited

Loading

annetill May 7, 2024

annetill May 3, 2024

annetill May 7, 2024

annetill May 7, 2024

annetill May 7, 2024

annetill May 7, 2024

annetill May 7, 2024

annetill May 10, 2024

sonarqubecloud bot commented May 7, 2024

annetill May 10, 2024

annetill May 10, 2024


		public static final String NAME = "lineAsymmetrical";

		private ComplexMatrix yabc; // a three phase admittance matrix can be provided in input and will be used as first option if not null

Support of asymmetrical transformer #806

Are you sure you want to change the base?

Support of asymmetrical transformer #806

Conversation

JB-H commented Jun 27, 2023

sonarqubecloud bot commented Oct 12, 2023

sonarqubecloud bot commented Dec 9, 2023

Choose a reason for hiding this comment

annetill May 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented May 7, 2024

Quality Gate passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annetill May 6, 2024 •

edited

Loading