Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AC vectorized network #778

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

AC vectorized network #778

wants to merge 54 commits into from

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented May 2, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Performance improvement, around 20% in a security analysis on a large case.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

geofjamg added 14 commits April 27, 2023 14:49
@geofjamg
AC equations vectorization
400296f 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
abc78d1 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
c915bae 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
3257ef1 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
759294c 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
2177030 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
0311565 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
c463e66 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
daa5d56 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
7436aa9 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Merge branch 'main' into ac_network_vector
7413eaf 
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/ac/equations/OpenBranchSide1ActiveFlowEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/OpenBranchSide1ReactiveFlowEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/OpenBranchSide2ActiveFlowEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/OpenBranchSide2ReactiveFlowEquationTerm.java
@geofjamg
Wip
a1107ef 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
cf5205b 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
91d7f6d 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg geofjamg changed the title AC vectorized network [WIP] AC vectorized network May 2, 2023
geofjamg and others added 12 commits May 24, 2023 21:59
@geofjamg
Merge branch 'main' into ac_network_vector
752cbf9
@geofjamg
Merge branch 'main' into ac_network_vector
29239bf 
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/ac/equations/AbstractBranchAcFlowEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/AbstractClosedBranchAcFlowEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/ClosedBranchSide1ActiveFlowEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/ClosedBranchSide1CurrentMagnitudeEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/ClosedBranchSide1ReactiveFlowEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/ClosedBranchSide2ActiveFlowEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/ClosedBranchSide2CurrentMagnitudeEquationTerm.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/ClosedBranchSide2ReactiveFlowEquationTerm.java
@geofjamg
Fix merge
ce82e23 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Merge branch 'main' into ac_network_vector
f75ae54
@geofjamg
Merge branch 'main' into ac_network_vector
a17ba61
@geofjamg
Merge branch 'main' into ac_network_vector
796cd45
@geofjamg
Wip
cc3e013 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
d702771 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
fe60742 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
d3b2b4d 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Merge branch 'main' into ac_network_vector
2c8db19
@geofjamg
Merge branch 'main' into ac_network_vector
00c1e16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

97.3% 97.3% Coverage
0.7% 0.7% Duplication

@annetill annetill requested a review from flo-dup October 11, 2023 08:36
@geofjamg
Merge branch 'main' into ac_network_vector
e892d15 
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java
@geofjamg
Wip
f95fead 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Merge remote-tracking branch 'origin/ac_network_vector' into ac_netwo…
a99a618 
…rk_vector
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

97.3% 97.3% Coverage
0.7% 0.7% Duplication

geofjamg added 16 commits December 2, 2023 10:08
@geofjamg
Merge branch 'main' into ac_network_vector
88ae320 
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/asym/AsymmetricalAcEquationSystemCreator.java
@geofjamg
Wip
5e06ec6 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
378b6de 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
8344582 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
6ed47b6 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Merge branch 'main' into ac_network_vector
fbd0b50 
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java
@geofjamg
Wip
88f6e7a 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Merge branch 'main' into ac_network_vector
bfdfebb
@geofjamg
Wip
0747f19 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Merge branch 'main' into ac_network_vector
ef6b455
@geofjamg
Wip
5d38fc6 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Merge branch 'main' into ac_network_vector
52b6c1b
@geofjamg
Merge branch 'main' into ac_network_vector
7634f6b
@geofjamg
Wip
4b5e74e 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
9ef48f5 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg
Wip
44480b7 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@geofjamg
Merge branch 'main' into ac_network_vector
d80b1ac 
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/network/impl/PropagatedContingency.java
@geofjamg
Merge branch 'main' into ac_network_vector
e7ec3cd 
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemUpdater.java
#	src/main/java/com/powsybl/openloadflow/ac/equations/asym/AsymmetricalAcEquationSystemCreator.java
#	src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java
@geofjamg
Merge
0a4beff 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@geofjamg
Merge branch 'main' into ac_network_vector
4016d05 
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java
@geofjamg
Fix
0c2df8d 
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annetill annetill Awaiting requested review from annetill

@flo-dup flo-dup Awaiting requested review from flo-dup

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geofjamg