[WIP] Fix SA reports in MT - Note; currently on top of report_test_format #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
requested review from
geofjamg,
Meklo,
obrix,
SylvestreSakti and
p-arvy
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
geofjamg
reviewed
Jan 9, 2025
src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java
Outdated
Show resolved
Hide resolved
…anism to address Sonar warning Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
changed the title
Signed-off-by: Didier Vidal <[email protected]>
|
Signed-off-by: Didier Vidal <[email protected]>
|
Reducing the list of reviewers now that the implementation is based on report postprocessing. |
vidaldid-rte
changed the title
vidaldid-rte
commented
Feb 28, 2025
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
… to report action issues Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
changed the title
| /** | ||
| * Copyright (c) 2025, Coreso SA (https://www.coreso.eu/) and TSCNET Services GmbH (https://www.tscnet.eu/) | ||
| * Copyright (c) 2022, RTE (http://www.rte-france.com) | ||
| /* |
There was a problem hiding this comment.
Coreso's copyright line is missing
| " Outer loop VoltageMonitoring\n" + | ||
| " Outer loop ReactiveLimits\n" + | ||
| " AC load flow completed successfully (solverStatus=CONVERGED, outerloopStatus=STABLE)"; | ||
| // Remove Windows EOL for comparison |
There was a problem hiding this comment.
This comment can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: needs this PR to build: powsybl/powsybl-core#3303
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Some issues are reported in #1167
What kind of change does this PR introduce?
There are some issues with Security Analysis in MT:
This PR fixes those issues
What is the new behavior (if this is a feature change)?
One report node per CC that contains in order:
One instance of network loading
One instance of precontingency run
All postcontingency results for that CC
The report is the same in single thread or multithread except that the contingency order may change.
In multi-thread mode, the check to verify that an operator strategy is associated to a contingency is not performed.
Does this PR introduce a breaking change or deprecate an API?