Fix injections ignored on first slack bus when using multiple slacks #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of first slack Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
| void loadOnSlackBusTest(boolean ac) { | ||
| @ParameterizedTest(name = "ac : {0}, switchSlacks : {1}") | ||
| @MethodSource("allModelAndSwitchingTypes") | ||
| void loadOnSlackBusTest(boolean ac, boolean switchSlacks) { |
There was a problem hiding this comment.
Could you add another test that runs one (or more models) with one slack and without multiple and checks that the solution is close enough ? (bus injections, bus voltage, terminal flows...)
There was a problem hiding this comment.
Yes, done a few minutes ago, I'll add more asserts to check bus injections, bus voltages as you mentioned (in the test differentNbSlackbusesTest)
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
A previous PR (#1116) fixes injections that are ignored in slack buses when using multiple slacks. But actually, the problem is just partially solved because injections are still ignored when being in the first slack. This is due to the distribution equations.
What is the current behavior?
Example with 3 slack buses
Before the previous fix (#1116) we had these distribution equation between slacks :
slack_p2 - slack_p1 = 0
slack_p3 - slack_p1 = 0
After the previous fix (#1116) we had these distribution equation between slacks :
slack_p2 - slack_p1 = target_p2
slack_p3 - slack_p1 = target_p3
What is the new behavior (if this is a feature change)?
Now we have these distribution equation between slacks :
slack_p2 - slack_p1 = target_p2 - target_p1
slack_p3 - slack_p1 = target_p3 - target_p1
Does this PR introduce a breaking change or deprecate an API?
Other information: