[WIP] Automatic fix of incompatible target voltages #1115
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| /** | ||
| * Copyright (c) 2024, RTE (http://www.rte-france.com) | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
| package com.powsybl.openloadflow; | ||
|
|
||
| import com.google.common.base.Stopwatch; | ||
| import com.powsybl.openloadflow.adm.AdmittanceEquationSystem; | ||
| import com.powsybl.openloadflow.adm.AdmittanceMatrix; | ||
| import com.powsybl.openloadflow.equations.VariableSet; | ||
| import com.powsybl.openloadflow.network.LfBranch; | ||
| import com.powsybl.openloadflow.network.LfBus; | ||
| import com.powsybl.openloadflow.network.LfNetwork; | ||
| import org.apache.commons.lang3.mutable.MutableInt; | ||
| import org.apache.commons.lang3.tuple.Pair; | ||
| import org.jgrapht.Graph; | ||
| import org.jgrapht.graph.Pseudograph; | ||
| import org.jgrapht.traverse.BreadthFirstIterator; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import java.util.*; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * @author Geoffroy Jamgotchian {@literal <geoffroy.jamgotchian at rte-france.com>} | ||
| */ | ||
| public class TargetVoltageCompatibilityChecker { | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(TargetVoltageCompatibilityChecker.class); | ||
|
|
||
| private final LfNetwork network; | ||
|
|
||
vidaldid-rte marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| public TargetVoltageCompatibilityChecker(LfNetwork network) { | ||
| this.network = Objects.requireNonNull(network); | ||
| } | ||
|
|
||
| private static Graph<LfBus, LfBranch> createGraph(LfNetwork lfNetwork) { | ||
| Graph<LfBus, LfBranch> graph = new Pseudograph<>(LfBranch.class); | ||
| for (LfBranch branch : lfNetwork.getBranches()) { | ||
| LfBus bus1 = branch.getBus1(); | ||
| LfBus bus2 = branch.getBus2(); | ||
| if (bus1 != null && bus2 != null && !branch.isDisabled()) { | ||
| if (!graph.containsVertex(bus1)) { | ||
| graph.addVertex(bus1); | ||
| } | ||
| if (!graph.containsVertex(bus2)) { | ||
| graph.addVertex(bus2); | ||
| } | ||
| graph.addEdge(bus1, bus2, branch); | ||
| } | ||
| } | ||
| return graph; | ||
| } | ||
|
|
||
| private static Set<LfBus> exploreNeighbors(Graph<LfBus, LfBranch> graph, LfBus bus, int maxDepth) { | ||
| var it = new BreadthFirstIterator<>(graph, bus); | ||
| Set<LfBus> neighbors = new HashSet<>(); | ||
| while (it.hasNext()) { | ||
| LfBus b = it.next(); | ||
| int currentDepth = it.getDepth(b); | ||
| if (currentDepth > maxDepth) { | ||
| break; | ||
| } | ||
| if (b != bus) { | ||
| neighbors.add(b); | ||
| } | ||
| } | ||
| return neighbors; | ||
| } | ||
|
|
||
| public List<Pair<LfBus, LfBus>> check(TargetVoltageCompatibilityCheckerParameters parameters) { | ||
| Stopwatch stopwatch = Stopwatch.createStarted(); | ||
|
|
||
| Graph<LfBus, LfBranch> graph = createGraph(network); | ||
|
|
||
| Set<LfBus> controlledBuses = network.getBuses().stream() | ||
| .filter(bus -> !bus.isDisabled() | ||
| && bus.isVoltageControlled() | ||
| && bus.getVoltageControls().stream().anyMatch(vc -> !vc.isDisabled())) | ||
| .collect(Collectors.toSet()); | ||
|
|
||
| List<Pair<LfBus, LfBus>> incompatibleControlledBuses = new ArrayList<>(); | ||
|
|
||
| var ySystem = AdmittanceEquationSystem.create(network, new VariableSet<>()); | ||
| try (var y = AdmittanceMatrix.create(ySystem, parameters.getMatrixFactory())) { | ||
| for (LfBus controlledBus : controlledBuses) { | ||
|
There was a problem hiding this comment. Don't you compute the impedance between each pair of bus twice ? if you iterate on all buses then on all neighbours ? Also, would it accerlerate things if there was an option to check a pair only if at least one of the two buses is remotely controlled ? [This is where we have convergence issues] There was a problem hiding this comment. Yes, we are checking potentially twice. It could be improved indeed. |
||
| Set<LfBus> neighborControlledBuses = exploreNeighbors(graph, controlledBus, parameters.getControlledBusNeighborsExplorationDepth()) | ||
| .stream().filter(controlledBuses::contains) | ||
| .collect(Collectors.toSet()); | ||
| if (!neighborControlledBuses.isEmpty()) { | ||
| for (LfBus neighborControlledBus : neighborControlledBuses) { | ||
| double z = y.getZ(controlledBus, neighborControlledBus).abs(); | ||
| double dv = Math.abs(controlledBus.getHighestPriorityTargetV().orElseThrow() - neighborControlledBus.getHighestPriorityTargetV().orElseThrow()); | ||
| double targetVoltagePlausibility = dv / z; | ||
| if (targetVoltagePlausibility > parameters.getTargetVoltagePlausibilityThreshold()) { | ||
| incompatibleControlledBuses.add(Pair.of(controlledBus, neighborControlledBus)); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| LOGGER.debug("Target voltage compatibility checked in {} ms", stopwatch.elapsed().toMillis()); | ||
|
|
||
| return incompatibleControlledBuses; | ||
| } | ||
|
|
||
| public void fix(TargetVoltageCompatibilityCheckerParameters parameters) { | ||
| List<Pair<LfBus, LfBus>> incompatibleControlledBuses = check(parameters); | ||
| // some buses could be part of multiple target v incompatible buses couples | ||
| // fix the most referenced ones | ||
| Map<LfBus, MutableInt> incompatibleControlledBusRefCount = new HashMap<>(); | ||
| for (Pair<LfBus, LfBus> p : incompatibleControlledBuses) { | ||
| incompatibleControlledBusRefCount.computeIfAbsent(p.getLeft(), k -> new MutableInt(0)).increment(); | ||
| incompatibleControlledBusRefCount.computeIfAbsent(p.getRight(), k -> new MutableInt(0)).increment(); | ||
| } | ||
| Set<LfBus> fixedControlledBuses = new HashSet<>(); | ||
| for (Pair<LfBus, LfBus> p : incompatibleControlledBuses) { | ||
| LfBus controlledBus1 = p.getLeft(); | ||
| LfBus controlledBus2 = p.getRight(); | ||
| if (fixedControlledBuses.contains(controlledBus1) || fixedControlledBuses.contains(controlledBus2)) { | ||
| continue; | ||
| } | ||
| LfBus controlledBusToFix = incompatibleControlledBusRefCount.get(controlledBus1).intValue() > incompatibleControlledBusRefCount.get(controlledBus2).intValue() | ||
| ? controlledBus1 : controlledBus2; | ||
| for (var voltageControl : controlledBusToFix.getVoltageControls()) { | ||
| LOGGER.warn("Controlled buses '{}' and '{}' have incompatible target voltages ({} and {}): disable voltage control of '{}'", | ||
| controlledBus1.getId(), controlledBus2.getId(), controlledBus1.getHighestPriorityTargetV().orElseThrow() * controlledBus1.getNominalV(), | ||
| controlledBus2.getHighestPriorityTargetV().orElseThrow() * controlledBus2.getNominalV(), controlledBusToFix.getId()); | ||
| voltageControl.setDisabled(true); | ||
| fixedControlledBuses.add(controlledBusToFix); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /** | ||
| * Copyright (c) 2024, RTE (http://www.rte-france.com) | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
| package com.powsybl.openloadflow; | ||
|
|
||
| import com.powsybl.math.matrix.MatrixFactory; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * @author Geoffroy Jamgotchian {@literal <geoffroy.jamgotchian at rte-france.com>} | ||
| */ | ||
| public class TargetVoltageCompatibilityCheckerParameters { | ||
|
|
||
| public static final int CONTROLLED_BUS_NEIGHBORS_EXPLORATION_DEPTH_DEFAULT_VALUE = 2; | ||
|
|
||
| public static final double TARGET_VOLTAGE_PLAUSIBILITY_THRESHOLD_DEFAULT_VALUE = 10; | ||
|
|
||
| private MatrixFactory matrixFactory; | ||
|
|
||
| private int controlledBusNeighborsExplorationDepth = CONTROLLED_BUS_NEIGHBORS_EXPLORATION_DEPTH_DEFAULT_VALUE; | ||
|
|
||
| private double targetVoltagePlausibilityThreshold = TARGET_VOLTAGE_PLAUSIBILITY_THRESHOLD_DEFAULT_VALUE; | ||
|
|
||
| public MatrixFactory getMatrixFactory() { | ||
| return matrixFactory; | ||
| } | ||
|
|
||
| public void setMatrixFactory(MatrixFactory matrixFactory) { | ||
| this.matrixFactory = Objects.requireNonNull(matrixFactory); | ||
| } | ||
|
|
||
| public TargetVoltageCompatibilityCheckerParameters(MatrixFactory matrixFactory) { | ||
| this.matrixFactory = Objects.requireNonNull(matrixFactory); | ||
| } | ||
|
|
||
| public int getControlledBusNeighborsExplorationDepth() { | ||
| return controlledBusNeighborsExplorationDepth; | ||
| } | ||
|
|
||
| public TargetVoltageCompatibilityCheckerParameters setControlledBusNeighborsExplorationDepth(int controlledBusNeighborsExplorationDepth) { | ||
| this.controlledBusNeighborsExplorationDepth = controlledBusNeighborsExplorationDepth; | ||
| return this; | ||
| } | ||
|
|
||
| public double getTargetVoltagePlausibilityThreshold() { | ||
| return targetVoltagePlausibilityThreshold; | ||
| } | ||
|
|
||
| public TargetVoltageCompatibilityCheckerParameters setTargetVoltagePlausibilityThreshold(double targetVoltagePlausibilityThreshold) { | ||
| this.targetVoltagePlausibilityThreshold = targetVoltagePlausibilityThreshold; | ||
| return this; | ||
| } | ||
|
|
||
| public String toString() { | ||
| return "TargetVoltageCompatibilityCheckerParameters(" + | ||
| "controlledBusNeighborsExplorationDepth=" + controlledBusNeighborsExplorationDepth + | ||
| ", targetVoltagePlausibilityThreshold=" + targetVoltagePlausibilityThreshold + | ||
| ", matrixFactory=" + matrixFactory.getClass().getSimpleName() + | ||
| ")"; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be documented.
And maybe addiotional parameters given like TARGET_VOLTAGE_PLAUSIBILITY_THRESHOLD
However in my test networks, increasing CONTROLLED_BUS_NEIGHBORS_EXPLORATION_DEPTH had a terrible algotirhmic cost and didn't improve quality (defined as more convergence)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"And maybe addiotional parameters given like TARGET_VOLTAGE_PLAUSIBILITY_THRESHOLD" => yes
for CONTROLLED_BUS_NEIGHBORS_EXPLORATION_DEPTH indeed it should not be configurable, a value of 2 or 3 is probably enough.