Report buses out of realistic voltage range in sub reports #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandemanged
requested changes
Oct 18, 2024
jeandemanged
requested changes
Oct 21, 2024
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
TheMaskedTurtle
force-pushed
the
jorism/report-buses-oor
branch
from
9ea5d83 to
1b6b732
Compare
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
jeandemanged
changed the title
vidaldid-rte
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
I don't think that TRACE is the right severity level for the message displaying the bus names, since users need to know them in order to fix the problem as explained in a previous comment.
But if no application developer is shouting I have no reason to block at this time. Hence my approval.
|
jeandemanged
approved these changes
Nov 27, 2024
vidaldid-rte
pushed a commit
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Joris Mancini <[email protected]> Signed-off-by: Didier Vidal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Split a report where a message can be really big into smaller sub-reports
What is the current behavior?
We're creating a report with a message based on a map that gathers all the network elements that are in error. This list can be really big and we feel this is not a good practice to do so.
What is the new behavior (if this is a feature change)?
Instead of one report gathering all the detailed information we split it into sub-reports with TRACE level and one summary message with ERROR level
Does this PR introduce a breaking change or deprecate an API?