Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issue if the user model has attribute with data name #729

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

oivoodoo
Copy link
Contributor

@oivoodoo oivoodoo commented Apr 3, 2024

No description provided.

@danschultzer
Copy link
Collaborator

danschultzer commented Apr 3, 2024

Great catch. Adding the field to Pow.Test.Ecto.Users.User does give us a guarantee that we always test it, but I think it may be better to be more precise and just test the functions explicitly in Pow.Ecto.Schema.ChangesetTest with a struct that has a data attribute. It seems that in other modules I did check for Changeset struct correctly, but in several functions in Pow.Ecto.Schema.Changeset it is missing.

@oivoodoo
Copy link
Contributor Author

oivoodoo commented Apr 3, 2024

@danschultzer you are definitely right about it, let me give a try to update changeset test cases. I had the issue with my user model in the project and tried to figure out the problem and come with fast fix to resolve the problem. Thank you!

@oivoodoo
Copy link
Contributor Author

Hi @danschultzer

Could you check the current changes when you have time?

Thank you!

@danschultzer
Copy link
Collaborator

❤️

@danschultzer danschultzer merged commit dac675c into pow-auth:main Apr 11, 2024
3 checks passed
@danschultzer
Copy link
Collaborator

Released with v1.0.38

@oivoodoo oivoodoo deleted the fix-type-bug branch April 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants