-
-
Notifications
You must be signed in to change notification settings - Fork 43
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #124 from pow-auth/add-finch
Add Finch adapter
- Loading branch information
Showing
8 changed files
with
186 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| if Code.ensure_loaded?(Finch) do | ||
| defmodule Assent.HTTPAdapter.Finch do | ||
| @moduledoc """ | ||
| HTTP adapter module for making http requests with Finch. | ||
| The Finch adapter must be configured with the supervisor by passing it as an | ||
| option: | ||
| http_adapter: {Assent.HTTPAdapter.Finch, [supervisor: MyFinch]} | ||
| See `Assent.HTTPAdapter` for more. | ||
| """ | ||
| alias Assent.{HTTPAdapter, HTTPAdapter.HTTPResponse} | ||
|
|
||
| @behaviour HTTPAdapter | ||
|
|
||
| @impl HTTPAdapter | ||
| def request(method, url, body, headers, finch_opts \\ nil) do | ||
| headers = headers ++ [HTTPAdapter.user_agent_header()] | ||
| opts = finch_opts || [] | ||
|
|
||
| supervisor = Keyword.get(opts, :supervisor) || raise "Missing `:supervisor` option for the #{inspect __MODULE__} configuration" | ||
| build_opts = Keyword.get(opts, :build, []) | ||
| request_opts = Keyword.get(opts, :request, []) | ||
|
|
||
| method | ||
| |> Finch.build(url, headers, body, build_opts) | ||
| |> Finch.request(supervisor, request_opts) | ||
| |> case do | ||
| {:ok, response} -> {:ok, %HTTPResponse{status: response.status, headers: response.headers, body: response.body}} | ||
| {:error, error} -> {:error, error} | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| defmodule Assent.HTTPAdapter.FinchTest do | ||
| use ExUnit.Case | ||
| doctest Assent.HTTPAdapter.Finch | ||
|
|
||
| alias Assent.HTTPAdapter.Finch, as: FinchAdapter | ||
| alias Assent.HTTPAdapter.HTTPResponse | ||
| alias Finch.Error | ||
|
|
||
| import ExUnit.CaptureLog | ||
|
|
||
| describe "request/4" do | ||
| test "without supervisor" do | ||
| TestServer.start(scheme: :https) | ||
|
|
||
| assert_raise RuntimeError, "Missing `:supervisor` option for the Assent.HTTPAdapter.Finch configuration", fn -> | ||
| FinchAdapter.request(:get, TestServer.url(), nil, []) | ||
| end | ||
| end | ||
|
|
||
| test "handles HTTP/1" do | ||
| TestServer.add("/", via: :get) | ||
|
|
||
| supervisor = start_supervised_finch!(protocol: :http1) | ||
|
|
||
| assert {:ok, %HTTPResponse{status: 200, body: "HTTP/1.1"}} = FinchAdapter.request(:get, TestServer.url(), nil, [], supervisor: supervisor) | ||
| end | ||
|
|
||
| test "handles SSL" do | ||
| TestServer.start(scheme: :https) | ||
| TestServer.add("/", via: :get) | ||
|
|
||
| supervisor = start_supervised_finch!(conn_opts: [transport_opts: [cacerts: TestServer.x509_suite().cacerts]]) | ||
|
|
||
| assert {:ok, %HTTPResponse{status: 200, body: "HTTP/2"}} = FinchAdapter.request(:get, TestServer.url(), nil, [], supervisor: supervisor) | ||
| end | ||
|
|
||
| test "handles SSL with bad certificate" do | ||
| TestServer.start(scheme: :https) | ||
|
|
||
| supervisor = start_supervised_finch!(conn_opts: [transport_opts: [cacerts: TestServer.x509_suite().cacerts]]) | ||
|
|
||
| bad_host_url = TestServer.url(host: "bad-host.localhost") | ||
|
|
||
| assert capture_log(fn -> | ||
| assert {:error, %Error{reason: :disconnected}} = FinchAdapter.request(:get, bad_host_url, nil, [], supervisor: supervisor) | ||
| end) =~ "{bad_cert,hostname_check_failed}" | ||
| end | ||
|
|
||
| test "handles SSL with bad certificate and no verification" do | ||
| TestServer.start(scheme: :https) | ||
| TestServer.add("/", via: :get) | ||
|
|
||
| supervisor = start_supervised_finch!(conn_opts: [transport_opts: [cacerts: TestServer.x509_suite().cacerts, verify: :verify_none]]) | ||
|
|
||
| bad_host_url = TestServer.url(host: "bad-host.localhost") | ||
|
|
||
| assert {:ok, %HTTPResponse{status: 200}} = FinchAdapter.request(:get, bad_host_url, nil, [], supervisor: supervisor) | ||
| end | ||
|
|
||
| test "handles unreachable host" do | ||
| TestServer.start() | ||
| url = TestServer.url() | ||
| TestServer.stop() | ||
|
|
||
| supervisor = start_supervised_finch!() | ||
|
|
||
| assert capture_log(fn -> | ||
| assert {:error, %Error{reason: :disconnected}} = FinchAdapter.request(:get, url, nil, [], supervisor: supervisor) | ||
| end) =~ "connection refused" | ||
| end | ||
|
|
||
| test "handles query in URL" do | ||
| TestServer.add("/get", via: :get, to: fn conn -> | ||
| assert conn.query_string == "a=1" | ||
|
|
||
| Plug.Conn.send_resp(conn, 200, "") | ||
| end) | ||
|
|
||
| supervisor = start_supervised_finch!() | ||
|
|
||
| assert {:ok, %HTTPResponse{status: 200}} = FinchAdapter.request(:get, TestServer.url("/get?a=1"), nil, [], supervisor: supervisor) | ||
| end | ||
|
|
||
| test "handles POST" do | ||
| TestServer.add("/post", via: :post, to: fn conn -> | ||
| {:ok, body, conn} = Plug.Conn.read_body(conn, []) | ||
| params = URI.decode_query(body) | ||
|
|
||
| assert params["a"] == "1" | ||
| assert params["b"] == "2" | ||
| assert Plug.Conn.get_req_header(conn, "content-type") == ["application/x-www-form-urlencoded"] | ||
|
|
||
| Plug.Conn.send_resp(conn, 200, "") | ||
| end) | ||
|
|
||
| supervisor = start_supervised_finch!() | ||
|
|
||
| assert {:ok, %HTTPResponse{status: 200}} = FinchAdapter.request(:post, TestServer.url("/post"), "a=1&b=2", [{"content-type", "application/x-www-form-urlencoded"}], supervisor: supervisor) | ||
| end | ||
| end | ||
|
|
||
| defp start_supervised_finch!(opts \\ []) do | ||
| start_supervised!({Finch, name: FinchTest, pools: %{:default => Keyword.put_new(opts, :protocol, :http2)}}) | ||
|
|
||
| FinchTest | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters