Add fork logic for ePBS #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Apr 17, 2024
specs/_features/epbs/fork.md
Outdated
Comment on lines
121
to
122
| previous_inclusion_list_proposer=0, # [New in ePBS] | ||
| previous_inclusion_list_slot=0, # [New in ePBS] |
There was a problem hiding this comment.
You need to set these to be the latest proposer/slot so that you can import the first payload, and the payload signature verification has to have an exception to not verify a signature from an IL before the fork.
There was a problem hiding this comment.
I pushed it. It's now
previous_inclusion_list_proposer=get_beacon_proposer_index(pre), # [New in ePBS]
previous_inclusion_list_slot=pre.slot, # [New in ePBS]
I wont do the beacon chain changes in this PR but let's make a note of that
specs/_features/epbs/fork.md
Outdated
Comment on lines
123
to
125
| latest_inclusion_list_proposer=0, # [New in ePBS] | ||
| latest_inclusion_list_slot=0, # [New in ePBS] | ||
| latest_block_hash=Hash32(), # [New in ePBS] |
terencechain
force-pushed
the
add-fork-logic
branch
from
233df42 to
1d56ca8
Compare
potuz
reviewed
Apr 25, 2024
specs/_features/epbs/fork.md
Outdated
| latest_inclusion_list_proposer=0, # [New in ePBS] | ||
| latest_inclusion_list_slot=0, # [New in ePBS] | ||
| latest_block_hash=Hash32(), # [New in ePBS] | ||
| latest_full_slot=0, # [New in ePBS] |
There was a problem hiding this comment.
Perhaps this one should also be pre.slot, there's no real use for this yet, but better to be safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to review the case of how the inclusion list import restriction is handled at the first slot of the ePBS fork epoch.