Fix some forkchoice typos #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
Apr 16, 2024
|
|
||
| assert block.slot > slot | ||
| parent = store.blocks[block.parent_root] | ||
| if parent.slot > slot: | ||
| return get_ancestor(store, block.parent_root, slot) | ||
| if block.body.signed_execution_payload_header.message.parent_block_hash == | ||
| parent.body.signed_execution_payload_header.message.block_hash: | ||
| if block.body.signed_execution_payload_header.message.parent_block_hash == parent.body.signed_execution_payload_header.message.block_hash: |
There was a problem hiding this comment.
I think this needs to be one line or python test generation will fail
terencechain
commented
Apr 16, 2024
| @@ -150,7 +150,7 @@ def block_for_inclusion_list(store: Store, inclusion_list: InclusionList) -> Opt | |||
|
|
|||
| blocks = blocks_for_slot(store, summary.slot) | |||
| for block in blocks: | |||
| if block.slot == summary.slot and block.proposer_index == summary.proposer_index and block.signed_execution_payload_header.message.parent_block_hash == parent_hash: | |||
There was a problem hiding this comment.
I dont think you need the slot check. Please correct me if I'm wrong here. blocks_for_slot(store, summary.slot) already covers that
potuz
reviewed
Apr 16, 2024
Co-authored-by: Potuz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.