104. Maximum Depth of Binary Tree #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oda
reviewed
May 26, 2025
| https://github.com/rossy0213/leetcode/pull/10/files | ||
|
|
||
| 再帰を使う選択肢は思い浮かばなかった・・・選択肢の一つにはしておきたい。 | ||
| next_nodesのリストを作っていって次のループに入る前にnodesに代入するやり方とtupleなどで深さも一緒に保存しておくやり方、どっちのが読みやすいですかね？ |
tokuhirat
reviewed
May 26, 2025
| if node.right is not None: | ||
| queue.append((node.right, depth + 1)) | ||
| return depth | ||
| ``` |
There was a problem hiding this comment.
読みやすかったです。Step2で見かけた再帰を使う方法も何も見ずに再現できるかを試してみると勉強になると思いました。
| while queue: | ||
| node, depth = queue.popleft() | ||
| append_if_not_none(node.left, depth + 1) | ||
| append_if_not_none(node.right, depth + 1) |
There was a problem hiding this comment.
個人的には append_if_exist などもありかなと感じました。
Fuminiton
reviewed
May 27, 2025
| def append_if_not_none(node, depth): | ||
| if node is not None: | ||
| queue.append((node, depth)) | ||
| depth = 0 |
There was a problem hiding this comment.
ここら辺にqueueの初期化があった方が分かりやすいと思いました。今回はヘルパー関数が短いので問題なさそうですが。
There was a problem hiding this comment.
上から読んでいったときにヘルパー関数の中でまだ導入されてない変数を操作することになるのでヘルパー変数の前に置く方がいいかなと思ったんですが、変数の定義はあとでも良いという人も多いんですかね？ 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/maximum-depth-of-binary-tree/description/