Implement pm.require #976
Merged
Implement pm.require #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coditva
commented
Feb 5, 2024
coditva
commented
Feb 15, 2024
package.json
Outdated
| @@ -92,7 +92,7 @@ | |||
| "terser": "^5.24.0", | |||
| "tsd-jsdoc": "^2.5.0", | |||
| "tv4": "1.3.0", | |||
| "uniscope": "2.0.1", | |||
| "uniscope": "postmanlabs/uniscope#feat/three-way-diff", | |||
There was a problem hiding this comment.
coditva
force-pushed
the
feat/script-require-pre-fetch
branch
from
1e089e6
to
eba9f5a
Compare
coditva
commented
Feb 16, 2024
coditva
commented
Feb 16, 2024
| return cache[path].exports; | ||
| } | ||
|
|
||
| /* eslint-disable-next-line one-var */ |
There was a problem hiding this comment.
@codenirvana I don't see the use of this eslint rule. I want to use const because the value never changes, but I don't want to evaluate it if I can bail out early. What're your thoughts?
coditva
force-pushed
the
feat/script-require-pre-fetch
branch
from
eba9f5a
to
198a140
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #976 +/- ##
===========================================
- Coverage 60.71% 60.56% -0.15%
===========================================
Files 12 12
Lines 560 563 +3
Branches 136 136
===========================================
+ Hits 340 341 +1
- Misses 220 222 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
coditva
force-pushed
the
feat/script-require-pre-fetch
branch
from
198a140
to
e7d4ed5
Compare
coditva
commented
Feb 16, 2024
package.json
Outdated
| @@ -43,7 +43,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "lodash": "4.17.21", | |||
| "postman-collection": "4.3.0", | |||
| "postman-collection": "aditya-baradwaj/postman-collection#feature/APITEST-766-Add-Packages-to-collection-schema", | |||
There was a problem hiding this comment.
coditva
force-pushed
the
feat/script-require-pre-fetch
branch
from
d90738f
to
acb1ca5
Compare
coditva
force-pushed
the
feat/script-require-pre-fetch
branch
from
277f79d
to
552088e
Compare
codenirvana
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
pm.requireto thepmAPI.When
resolvedPackagesoption is passed to the sandbox inexecute, thepm.requireAPI can be used to import the packages from theresolvedPackagescache.modules.exportis exported from the package.test/unit/sandbox-libraries/pm-require.test.jsfor more cases.Note: Commits e7d4ed5 and 42e7dcd can be removed once
postman-collectionanduniscopeare bumped.