Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pm.vault VariableScope #1003

Conversation

Pranav2612000
Copy link
Contributor

@Pranav2612000 Pranav2612000 commented May 20, 2024

Why do we need this change?

  • We want the user to be able to use the pm.vault to work with Vault Secrets.
  • get, set, clear, unset, toObject, toJSON etc all normal VariableScope operations are to be supported

How does it work?

  • Add the vaultSecrets to the execution context
  • Expose vault through pmapi
  • Update type files ( *.d.ts ) to export vault as VariableScope type

What changes are remaining

@Pranav2612000 Pranav2612000 force-pushed the feat/add-support-for-vault-secrets branch 3 times, most recently from 1ee79e0 to ea8a2fc Compare May 22, 2024 04:57
@Pranav2612000 Pranav2612000 force-pushed the feat/add-support-for-vault-secrets branch 2 times, most recently from fab52b9 to 97b55fb Compare July 2, 2024 10:07
@Pranav2612000 Pranav2612000 force-pushed the feat/add-support-for-vault-secrets branch 2 times, most recently from be27679 to 09865e2 Compare July 11, 2024 10:30
@Pranav2612000 Pranav2612000 changed the title [WIP] feat: add support for vault secrets in scripts [TRUST-1152] [TRUST-1210] feat: add support for vault secrets in scripts Jul 11, 2024
@Pranav2612000 Pranav2612000 changed the title [TRUST-1152] [TRUST-1210] feat: add support for vault secrets in scripts [TRUST-1152] [TRUST-1210] feat: add support for pm.vault in scripts Jul 11, 2024
@Pranav2612000 Pranav2612000 changed the title [TRUST-1152] [TRUST-1210] feat: add support for pm.vault in scripts [TRUST-1152] [TRUST-1207] feat: add support for pm.vault in scripts Jul 11, 2024
@Pranav2612000 Pranav2612000 force-pushed the feat/add-support-for-vault-secrets branch from 09865e2 to dfc6d6f Compare July 11, 2024 10:42
@Pranav2612000 Pranav2612000 marked this pull request as ready for review July 11, 2024 10:47
@Pranav2612000 Pranav2612000 changed the title [TRUST-1152] [TRUST-1207] feat: add support for pm.vault in scripts feat: add support for pm.vault in scripts Jul 12, 2024
@Pranav2612000 Pranav2612000 force-pushed the feat/add-support-for-vault-secrets branch from dfc6d6f to b7ae91c Compare July 15, 2024 09:33
@codenirvana codenirvana changed the title feat: add support for pm.vault in scripts Added support for pm.vault VariableScope Jul 29, 2024
@codenirvana codenirvana merged commit 7f48187 into postmanlabs:develop Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants