Partially addressed review comments

postmanlabs · Jul 10, 2024 · 77ebb18 · 77ebb18
1 parent 947ddc2
commit 77ebb18
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -46,7 +46,7 @@ function initParams (uri, options, callback) {
   }
 
   // Disable flow when running in browser
-  if (!tls.connect) {
+  if (typeof window !== 'undefined' && window.XMLHttpRequest) {
     params.protocolVersion = 'http1'
   }
 

diff --git a/lib/http2/http2Agent.js → lib/http2/agent.js b/lib/http2/http2Agent.js → lib/http2/agent.js
diff --git a/lib/http2/index.js b/lib/http2/index.js
@@ -1,4 +1,4 @@
-const { Http2Agent, globalAgent } = require('./http2Agent')
+const { Http2Agent, globalAgent } = require('./agent')
 const { request } = require('./request')
 
 module.exports = {

diff --git a/lib/http2/request.js b/lib/http2/request.js
@@ -1,7 +1,7 @@
 const url = require('url')
 const http2 = require('http2')
 const { EventEmitter } = require('events')
-const { globalAgent } = require('./http2Agent')
+const { globalAgent } = require('./agent')
 const { assertValidPseudoHeader, checkIsHttpToken } = require('../autohttp/utils/headers')
 
 function httpOptionsToUri (options) {

diff --git a/lib/redirect.js b/lib/redirect.js
@@ -210,8 +210,6 @@ Redirect.prototype.onResponse = function (response) {
 
   request.emit('redirect')
 
-  options.protocolVersion = this.request.protocolVersion
-
   // Wait for request to end before firing redirect request
   request._redirectPromise
     .then(() => {