[POA-2129] Separate out common apidump flags
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudit-postman
requested review from
mgritter
and removed request for
mgritter
mgritter
approved these changes
Nov 20, 2024
…into mudit/POA-2129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apidumpflags fromapidump.gotocommon_flags.go.common_flags.gohave two functions:AddCommonApiDumpFlags(): Add the flags to cobra.Command object. It returns the objects to which flag values will be assigned.ConvertCommonApiDumpFlagsToArgs(): Returns an array of strings (like--flag value). It is added to the apidump command in different platform installation configurations.ecsandec2commands will read these values and then convert them to flags forapidumpcommands and add them to the definition file (ecs) or systems service file (ec2)apidumpcommand will use these flag values to set the mainapidumppackage variables.