Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POA-1415] Re-enable support for EC2 commands #20

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[POA-1415] Re-enable support for EC2 commands #20

merged 2 commits into from
Jul 25, 2024

Conversation

mudit-postman
Copy link
Contributor

In this PR, we are re-enabling support for EC2 in our agent.
Changes done:

  • Replaced --collection flag with --project in EC2 command
  • Added a baseec2 command since the setup command can be confusing.
    • So postman-insights-agent setup ... -> postman-insights-agent ec2 setup ...
    • Only ec2 command also defaults to ec2 setup
  • Moved the CheckAPIKeyAndInsightsProjectID function out from ecs.go to check.go
  • Other small syntactic or typo changes

@mudit-postman mudit-postman requested a review from mgritter July 24, 2024 09:42
@mudit-postman mudit-postman marked this pull request as ready for review July 24, 2024 09:42
mgritter
mgritter approved these changes Jul 24, 2024
View reviewed changes
cmd/internal/cmderr/checks.go Outdated Show resolved Hide resolved
cmd/internal/cmderr/checks.go Outdated Show resolved Hide resolved
@mudit-postman mudit-postman merged commit 08d3460 into main Jul 25, 2024
2 checks passed
@mudit-postman mudit-postman deleted the mudit/POA-1415 branch July 25, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgritter mgritter mgritter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mudit-postman @mgritter