fix the randomAvatar dynamic variable url returning 404 in faker.js #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedkribhu
changed the title
vedkribhu
force-pushed
the
fix/avatar-random-variable
branch
3 times, most recently
from
ffa6a4c to
b915db0
Compare
vedkribhu
force-pushed
the
fix/avatar-random-variable
branch
from
b915db0 to
dc49d68
Compare
codenirvana
previously approved these changes
Jul 29, 2024
codenirvana
force-pushed
the
fix/avatar-random-variable
branch
from
4efaeb5 to
baf81f1
Compare
codenirvana
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL returned from faker v5.5.3 is not correct for avatars, we are overriding the function to return correct url as per latest faker js version.
We don't want to upgrade the version due to the size of the latest version.