Chore: update eslint rules

postmanlabs · Apr 6, 2020 · 4f5c378 · 4f5c378
1 parent f2d464d
commit 4f5c378
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -18,7 +18,10 @@
     "rules": {
         // Possible Errors
         "for-direction": "error",
+        "default-param-last": "error",
+        "function-call-argument-newline": "off",
         "getter-return": "error",
+        "no-async-promise-executor": "error",
         "no-await-in-loop": "error",
         "no-compare-neg-zero": "error",
         "no-cond-assign": "error",
@@ -27,8 +30,10 @@
         }],
         "no-constant-condition": "error",
         "no-control-regex": "error",
+        "no-constructor-return": "error",
         "no-debugger": "error",
         "no-dupe-args": "error",
+        "no-dupe-else-if": "error",
         "no-dupe-keys": "error",
         "no-duplicate-case": "error",
         "no-empty": "error",
@@ -38,9 +43,11 @@
         "no-extra-parens": "off",
         "no-extra-semi": "error",
         "no-func-assign": "error",
+        "no-import-assign": "error",
         "no-inner-declarations": "error",
         "no-invalid-regexp": "error",
         "no-irregular-whitespace": "error",
+        "no-misleading-character-class": "error",
         "no-obj-calls": "error",
         "no-prototype-builtins": "error",
         "no-regex-spaces": "error",
@@ -50,8 +57,10 @@
         "no-unreachable": "error",
         "no-unsafe-finally": "error",
         "no-unsafe-negation": "error",
+        "prefer-regex-literals": "error",
+        "require-atomic-updates": "error",
+        "require-unicode-regexp": "off",
         "use-isnan": "error",
-        "valid-jsdoc": "off",
         "valid-typeof": "error",
 
         // Best Practices
@@ -66,6 +75,7 @@
         "dot-location": ["error", "property"],
         "dot-notation": "error",
         "eqeqeq": "error",
+        "grouped-accessor-pairs": "warn",
         "guard-for-in": "warn",
         "max-classes-per-file": ["error", 1],
         "max-lines-per-function": "off",
@@ -110,6 +120,7 @@
         "no-self-assign": "error",
         "no-self-compare": "error",
         "no-sequences": "error",
+        "no-setter-return": "error",
         "no-throw-literal": "error",
         "no-unmodified-loop-condition": "error",
         "no-unused-expressions": "off",
@@ -121,6 +132,8 @@
         "no-void": "error",
         "no-warning-comments": "off",
         "no-with": "error",
+        "prefer-named-capture-group": "off",
+        "prefer-exponentiation-operator": "warn",
         "prefer-object-spread": "error",
         "prefer-promise-reject-errors": "error",
         "radix": "error",
@@ -134,7 +147,6 @@
 
         // Variables
         "init-declarations": "off",
-        "no-catch-shadow": "error",
         "no-delete-var": "error",
         "no-label-var": "error",
         "no-restricted-globals": "error",
@@ -281,7 +293,6 @@
         ],
         "quote-props": ["error", "as-needed"],
         "quotes": ["error", "single"],
-        "require-jsdoc": "warn",
         "semi": "error",
         "semi-spacing": "error",
         "semi-style": ["error", "last"],
@@ -316,6 +327,7 @@
         "no-new-symbol": "error",
         "no-restricted-imports": "error",
         "no-this-before-super": "error",
+        "no-useless-catch": "error",
         "no-useless-computed-key": "error",
         "no-useless-constructor": "error",
         "no-useless-rename": "error",
@@ -402,7 +414,7 @@
         "security/detect-eval-with-expression": "error",
         "security/detect-no-csrf-before-method-override": "error",
         "security/detect-non-literal-fs-filename": "off",
-        "security/detect-non-literal-regexp": "warn",
+        "security/detect-non-literal-regexp": "error",
         "security/detect-non-literal-require": "off",
         "security/detect-object-injection": "off",
         "security/detect-possible-timing-attacks": "error",

diff --git a/lib/run/summary.js b/lib/run/summary.js
@@ -25,13 +25,15 @@ RunSummary = function RunSummary (emitter, options) {
 
         /**
          * The environment that is being used during the run
+         *
          * @type {VariableScope}
          *
          */
         environment: _.get(options, 'environment'),
 
         /**
          * Global variables being used during the run
+         *
          * @type {VariableScope}
          */
         globals: _.get(options, 'globals'),

diff --git a/test/system/editorconfig.test.js b/test/system/editorconfig.test.js
@@ -6,6 +6,7 @@ var editorconfig = require('editorconfig'),
 
     /**
      * The width (in spaces) of tabs used for indentation throughout the project
+     *
      * @type {Number}
      */
     TAB_WIDTH = 4;
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,6 +6,7 @@ var editorconfig = require('editorconfig'), @@
         /**
          * The width (in spaces) of tabs used for indentation throughout the project
+         *
          * @type {Number}
          */
         TAB_WIDTH = 4;
@@ Expand Down @@