Skip to content

Commit

Permalink
Drop support for node < v18
Browse files Browse the repository at this point in the history
  • Loading branch information
appurva21 committed Sep 25, 2024
1 parent 74a4554 commit 3de1d3f
Show file tree
Hide file tree
Showing 23 changed files with 773 additions and 431 deletions.
380 changes: 175 additions & 205 deletions .eslintrc

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16, 18]
node-version: [18, 20]
os: [ubuntu-latest, windows-latest]

steps:
Expand All @@ -47,10 +47,10 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v3

- name: Use Node.js 20
- name: Use latest Node.js
uses: actions/setup-node@v3
with:
node-version: 20
node-version: latest
cache: "npm"

- name: Install
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
unreleased:
breaking changes:
- GH-1605 Dropped support for Node < v18
chores:
- GH-1605 Updated dependencies
- GH-1605 Updated ESLint rules
- GH-1605 Run code coverage on latest Node version in CI

6.2.1:
date: 2024-08-20
fixed bugs:
Expand Down
2 changes: 1 addition & 1 deletion lib/config/rc-file.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable no-process-env */
/* eslint-disable n/no-process-env */
var _ = require('lodash'),
fs = require('fs'),
join = require('path').join,
Expand Down
2 changes: 1 addition & 1 deletion lib/reporters/cli/cli-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ cliUtils = {
}

return {
exists: !(Boolean(process.env.CI) || !process.stdout.isTTY), // eslint-disable-line no-process-env
exists: !(Boolean(process.env.CI) || !process.stdout.isTTY), // eslint-disable-line n/no-process-env
width: width,
height: height
};
Expand Down
4 changes: 2 additions & 2 deletions lib/reporters/cli/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ PostmanCLIReporter = function (emitter, reporterOptions, options) {
}

reqText = wrap(reqText, ` ${colors.white(symbols.console.middle)} `);
// eslint-disable-next-line max-len
// eslint-disable-next-line @stylistic/js/max-len
print.buffer(` ${colors.white(symbols.console.top)} ${colors.white(symbols.up)} ${reqBodyMode} ${colors.gray(symbols.star)} ${util.filesize(reqTextLen)}\n`,
colors.white(` ${symbols.console.bottom}`))
// tweak the message to ensure that its surrounding is not brightly coloured.
Expand All @@ -278,7 +278,7 @@ PostmanCLIReporter = function (emitter, reporterOptions, options) {
}

resText = wrap(resText, ` ${colors.white(symbols.console.middle)} `);
// eslint-disable-next-line max-len
// eslint-disable-next-line @stylistic/js/max-len
print.buffer(` ${colors.white(symbols.console.top)} ${colors.white(symbols.down)} ${resSummary} ${colors.gray(symbols.star)} ${util.filesize(resTextLen)}\n`,
colors.white(` ${symbols.console.bottom}`))
// tweak the message to ensure that its surrounding is not brightly coloured.
Expand Down
2 changes: 1 addition & 1 deletion lib/run/export-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ module.exports = function (options, done) {
});
},
function (next) {
fs.stat(path.unparsed, function (err, stat) { // eslint-disable-line handle-callback-err
fs.stat(path.unparsed, function (err, stat) { // eslint-disable-line n/handle-callback-err
next(null, stat);
});
},
Expand Down
2 changes: 1 addition & 1 deletion lib/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ util = {
if (response.statusCode !== 200) {
const resource = isPostmanHost ? _(urlObj.getPath()).split('/').get(1).slice(0, -1) : 'resource',
error = new Error(_.get(body, 'error.message',
// eslint-disable-next-line max-len
// eslint-disable-next-line @stylistic/js/max-len
`Error fetching ${resource}, the provided URL returned status code: ${response.statusCode}`));

return callback(_.assign(error, {
Expand Down
Loading

0 comments on commit 3de1d3f

Please sign in to comment.