Fix for issue #47 - double free of COL_INFO object #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
progmachine
commented
Sep 26, 2024
progmachine
commented
- Fix for issue Memory Corruption using version 16.00.0005 #47 - double free of COL_INFO object due to refcount breakage during reuse of directly found object in getColumnsInfo(...).
- One more possible memory leak of COL_INFO objects in getColumnsInfo(...).
…ct due to refcount breakage during reuse of directly found object in getColumnsInfo(...). One more possible memory leak of COL_INFO objects in getColumnsInfo(...). Signed-off-by: Alexandr Kuznetsov <[email protected]>
davecramer
reviewed
Sep 26, 2024
parse.c
Outdated
| @@ -882,6 +882,8 @@ getColumnsInfo(ConnectionClass *conn, TABLE_INFO *wti, OID greloid, StatementCla | |||
| if (coli_exist) | |||
| { | |||
| /* We have ready to use coli object. Cleaning it. */ | |||
| tmp_refcnt = coli->refcnt; /* If we found coli with greloid, then some TABLE_INFO objects may have references to it -> save refcnt for them. */ | |||
| tmp_refcnt--; /* Down the road we will increase refcnt again to account for the refernce from ConnectionClass object to coli object. */ | |||
There was a problem hiding this comment.
spelling mistake "refernce" in comment
Signed-off-by: Alexandr Kuznetsov <[email protected]>
|
@progmachine Thankyou |
|
How do you think, do we need to make the 16.0.6 bugfix release? |
|
Yes, I am going to release 16.0.6 and then fast follow with 17 today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.