Fix subprocess.Popen.communicate type conflicts via defensive input normalizer (_BinDataBox) - #130
Merged
dmitry-lipetsk merged 1 commit intoSep 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a fundamental architecture limitation in Python's standard library
subprocess.Popeninside bothOsOperations::runandOsProcessController::communicatelayers. The issue manifests as a type conflict between textual and binary spaces when handling distributed pipelines that require a mixed execution model (e.g., streaming raw database dumps into standard input while capturing readable, decoded text logs viastdout/stderr).The Problem
Python's
subprocessassumes an all-or-nothing approach to I/O modes, causing heavy runtime crashes under two distinct scenarios:Binary Input in Text Mode (
text=True):When streaming raw binary data (e.g., database file chunks) into a process configured in text mode to capture human-readable errors, standard library's internal
_save_input()method blindly triggers.encode()on the target input:If the incoming
inputconsists of nativebytes, this call crashes immediately withAttributeError: 'bytes' object has no attribute 'encode', disrupting binary integrity before reaching the network socket/pipe.Text Input in Binary Mode (
text=False):Conversely, passing a string object into a binary execution pipeline triggers a delayed crash down the stack during the low-level selector chunking stage, where
memoryviewtries to map raw buffer regions:The Solution: Industrial-Grade Duck Typing
To maintain total data integrity without corrupting surrogate binary structures (such as blobs or heavy ICU collations) through unnecessary round-trip string conversions, we introduced a highly resilient duck-typed dispatcher wrapper via
Helpers::prepare_process_input:_BinDataBox(bytes): A lightweight subclass of nativebytesthat retains identical low-level memory layout performance (no duplication overhead) but exposes a safe, self-returning.encode()shim. This seamlessly cheats Python's internal_save_input()verification logic in text mode.memoryview, completely neutralising the threat of an implicitTypeError.Code Architecture Shift
Impact & Verification