Skip to content

Commit

Permalink
remove unused config settings
Browse files Browse the repository at this point in the history
  • Loading branch information
schldwcht committed Oct 20, 2023
1 parent 5e33e0b commit 26200a6
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 32 deletions.
16 changes: 10 additions & 6 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ to:

```text
V5: https://api.postcodeservice.com/nl/v5/find?zipcode=4201KB&houseno=63
See https://developers-staging.postcodeservice.com/#netherlands-api
```

- Added support for Belgium bilingual results in bilingual municipalities,
Expand All @@ -38,7 +39,7 @@ V3: https://api.postcodeservice.com/be/v3/zipcode-find?zipcodezone=1050&multires
"city": "Bruxelles",
"latitude": 50.8222854,
"longitude": 4.3815707
}
},
...
]
```
Expand Down Expand Up @@ -92,7 +93,8 @@ if (data.error_code) {
- Revised and updated the Magento User manual to ensure it matches the latest changes.
- Updated `SECURITY.md` with GitHub’s private reporting option, providing a secure channel for issue
reporting.
- Successfully tested the extension with the new Magento 2.4.7-beta1, Magento 2.4.7-beta2, confirming compatibility and
- Successfully tested the extension with the new Magento 2.4.7-beta1, Magento 2.4.7-beta2,
confirming compatibility and
performance.

## UX/UC improvements
Expand All @@ -102,13 +104,14 @@ if (data.error_code) {
in `postcode-nl.js`,
see comment `// The last parameter is the delay in millisecond` in the file.
- Similarly, decreased the loading speed of the address results for Belgium from 500 milliseconds to
50 milliseconds for
30 milliseconds for
streets and 30 milliseconds for zipcodes by default. This can be changed in `postcode-be.js`, see
twice
the comment `// Parameter for the results delay in milliseconds`.
- Eliminated the redundant loading screen for Nederlands in Magento Checkout, enhancing the overall
user experience in the vanilla Magento Luma checkout theme. You can still turn this on in the
file `postcode-api.js` in the method `getPostCodeNL` by setting the variable `showLoader: false` to `true`.
file `postcode-api.js` in the method `getPostCodeNL` by setting the variable `showLoader: false`
to `true`.
- Deactivated advanced settings that were not being utilized, thereby simplifying the user
interface.
- Added new documentation links from within the extension to the Magento User manual and underlying
Expand Down Expand Up @@ -144,5 +147,6 @@ if (data.error_code) {

## Release credits

- Thanks go out to the following people for contributing to this release: Robert, Tim S., Vincent, Erik de
Groot, Viktoriia and Peter S.
- Thanks go out to the following people for contributing to this release: Robert, Tim S., Vincent,
Erik de
Groot, Viktoria and Peter S.
6 changes: 0 additions & 6 deletions Plugin/Model/Checkout/LayoutProcessorPlugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,6 @@ public function afterProcess($subject, $jsLayout) {
// @TODO use a better way to set sort order for postcode field,
// tried in branch "tryout_billing_address_sortorder_mixin"

// @TODO remove debug data
/* $file = fopen('test.txt', 'a+');
fwrite($file, $defaultCountry . "--");
fclose($file);
*/

if ($defaultCountry === "NL" || $defaultCountry === "BE" || $defaultCountry === "DE") {
$jsLayout = $this->arrayManager->set($postalCodePath . '/config/sortOrder', $jsLayout, 50);
}
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
{
"name": "TIG",
"email": "[email protected]",
"homepage": "https://postcodeservice.nl/"
"homepage": "https://postcodeservice.com"
}
],
"support": {
"email": "[email protected]",
"issues": "https://portal.tig.nl"
"issues": "https://postcodeservice.com/support/"
},
"homepage": "https://postcodeservice.nl/",
"homepage": "https://postcodeservice.com",
"minimum-stability": "RC",
"autoload": {
"files": [
Expand Down
15 changes: 0 additions & 15 deletions etc/config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,6 @@
<enable_be_check>1</enable_be_check>
<enable_de_check>1</enable_de_check>
</countries>
<search_nl>
<results_delay_in_ms>30</results_delay_in_ms>
</search_nl>
<search_be>
<zipcode_results_delay_in_ms>30</zipcode_results_delay_in_ms>
<zipcode_results_max>8</zipcode_results_max>
<street_results_delay_in_ms>50</street_results_delay_in_ms>
<street_results_max>6</street_results_max>
</search_be>
<search_de>
<zipcode_results_delay_in_ms>30</zipcode_results_delay_in_ms>
<zipcode_results_max>8</zipcode_results_max>
<street_results_delay_in_ms>50</street_results_delay_in_ms>
<street_results_max>6</street_results_max>
</search_de>
</tig_postcode>
</default>
</config>
2 changes: 1 addition & 1 deletion view/base/web/js/postcode-handler/postcode-be.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ define(
streetField.attr('autocomplete', 'yes');

streetField.autocomplete({
delay: 50, // Parameter for the results delay in milliseconds
delay: 30, // Parameter for the results delay in milliseconds
source: function (street, response) {
var postcode = currentPostcodeService.getElement(FieldTypes.postcode).value();
var city = currentPostcodeService.getElement(FieldTypes.city).value();
Expand Down
2 changes: 1 addition & 1 deletion view/base/web/js/postcode-handler/postcode-de.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ define(
streetField.attr('autocomplete', 'yes');

streetField.autocomplete({
delay: 50, // Parameter for the results delay in milliseconds
delay: 30, // Parameter for the results delay in milliseconds
source: function (street, response) {
var postcode = currentPostcodeService.getElement(FieldTypes.postcode).value();
var city = currentPostcodeService.getElement(FieldTypes.city).value();
Expand Down

0 comments on commit 26200a6

Please sign in to comment.