feat(smtp): add config option to disable sending email via ipv6 #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
samip5
reviewed
Aug 10, 2024
| @@ -413,6 +413,11 @@ module Postal | |||
| description "The e-mail to use as the from address outgoing emails from Postal" | |||
| default "[email protected]" | |||
| end | |||
|
|
|||
| boolean :disable_ipv6 do | |||
| description "Disalbles sending emails via IPv6, only IPv4 will be used" | |||
There was a problem hiding this comment.
Noticed an typo, I think Disalbles should be Disables
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This quick feature adds a config flag allowing users to disable emailing via IPv6.
The inspiration behind this is a scenario I'm facing; I have a VPS with IPv4 and IPv6, but the IPv6 address is deny listed for some email hosts (like Gmail). I tried some workaround, like disabling IPv6 on the VM and disabling the DNS resolver from returning AAAA records, but this was the best and most reliable fix.
I'm sure I'm not the first user to hit an issue like this, so this would be helpful for everyone!