address PR review feedback on the Connect Cloud auth refactor - #841
Merged
samperman merged 2 commits intoAug 26, 2026
Merged
Conversation
Reject Connect-only deploy options for Connect Cloud. Reject --draft so the deploy step no longer cites a Connect version for a target that has no draft step at any version. Skip rewriting the store file when a save would not change it. DataStore._set always calls save(), so a Connect Cloud token refresh backed by the system keyring rewrote servers.json on every refresh with contents identical to what was already there, Guard the response status against None before comparing it, since a failed connection produces a response carrying only the exception. Trim the changelog entry, and rewrite two comments review found hard to follow.
|
karawoo
approved these changes
Aug 21, 2026
karawoo
left a comment
karawoo
left a comment
Contributor
There was a problem hiding this comment.
One question about the supported deploy options but otherwise lgtm
Comment on lines
+65
to
+72
| _CONNECT_ONLY_DEPLOY_OPTIONS: dict[str, str] = { | ||
| "image": "-I/--image", | ||
| "disable_env_management": "--disable-env-management", | ||
| "env_management_py": "--disable-env-management-py", | ||
| "env_management_r": "--disable-env-management-r", | ||
| "draft": "--draft", | ||
| "metadata": "--metadata", | ||
| } |
Contributor
There was a problem hiding this comment.
Should --disable-env-management-node and --node be included here too? What about --hide-all-input / --hide-tagged-input?
Collaborator
Author
There was a problem hiding this comment.
good catch on the node flags. i've added those to the list. As for the two hide flags, i think i'm going to leave those as is for now and instead investigate how to properly support them on the Connect Cloud side. I've created an issue there to track it.
A user targeting Connect Cloud via a saved nickname can reach deploy_nodejs; reject these options the same way as the other env-management flags.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject Connect-only deploy options for Connect Cloud.
Reject --draft so the deploy step no longer cites a Connect version for a target that has no draft step at any version.
Skip rewriting the store file when a save would not change it. DataStore._set always calls save(), so a Connect Cloud token refresh backed by the system keyring rewrote servers.json on every refresh with contents identical to what was already there,
Guard the response status against None before comparing it, since a failed connection produces a response carrying only the exception.
Trim the changelog entry, and rewrite two comments review found hard to follow.
Intent
PR feedback, will be merged into the main PR when ready: #840