Add ui.MarkdownStream
#1782
Draft
Add ui.MarkdownStream
#1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Nov 26, 2024
jcheng5
reviewed
Nov 26, 2024
cpsievert
force-pushed
the
markdown-stream-component
branch
from
026867b to
ba86904
Compare
cpsievert
force-pushed
the
markdown-stream-component
branch
from
a6f66a5 to
7cf0366
Compare
Since .stream() has clear=True, it doesn't really serve any purpose
cpsievert
force-pushed
the
markdown-stream-component
branch
from
4c7cbbc to
c295a54
Compare
cpsievert
force-pushed
the
markdown-stream-component
branch
from
c295a54 to
b304ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the streaming markdown capabilities of
ui.Chat()into another component:ui.MarkdownStream(). See the new files for example usage:shiny/api-examples/MarkdownStream/app-express.pyshiny/api-examples/MarkdownStream/app-core.pyWhile extracting out the markdown streaming portion, I also improved the 'auto-scroll' behavior. Now it should be easier to disable/enable auto scroll by scrolling away/towards the bottom of a scrollable parent of the stream
TODO
Follow up
shinychatchanges to pull/incorporate new assetsui.MarkdownStream()? If so, where should that live?