installer: gate cosign-absent warning behind PEV_VERBOSE - #7
Open
samcofer wants to merge 1 commit into
Open
Conversation
The SHA-256-only fallback warning printed on every install when cosign is not on PATH. cosign is not a documented prerequisite, so for the common case this is noise that reads like something went wrong. Route the notice through a new vlog() helper that prints only when PEV_VERBOSE=1, so operators auditing supply-chain verification can still surface the downgrade while the happy path stays quiet. The hard-fail opt-in (PEV_REQUIRE_COSIGN=1) is unchanged. vlog() ends in `return 0` so the short-circuit `&&` test does not trip `set -e` when PEV_VERBOSE is unset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The installer prints a
warning: cosign not on PATH; falling back to SHA-256 onlyline on every install wherecosignisn't present. cosign is not a documented prerequisite for pev, so on the common path this reads like something went wrong when nothing did — it was the source of confusion reported in the field.This routes that notice through a new
vlog()helper that only prints whenPEV_VERBOSE=1. The happy path stays quiet; operators auditing supply-chain verification can still surface the downgrade on demand.Not changed
PEV_REQUIRE_COSIGN=1is untouched — regulated installs that want a missing cosign to abort still get that.Safety note
vlog()ends inreturn 0so the short-circuit[ ... ] && printfdoesn't tripset -ewhenPEV_VERBOSEis unset. Verified withsh -n,shellcheck, and aset -eubehavior test in both quiet and verbose modes.🤖 Generated with Claude Code