Open
Conversation
The three-layer renderer hierarchy (Renderer → MdRenderer → bridge Renderer → assets Renderer) existed only to satisfy the old class structure. The new _render/ subpackage only uses the renderer as a config holder (3 properties).
RenderConfig was a pass-through dataclass threaded through every Render object but only consumed in two places. Move its properties to their natural homes: - display_name_format, signature_name_format → RenderDoc fields - header_level, typing_module_paths → Builder attributes - show_signature → already a RenderDoc field (redundant override removed) Delete _render_config.py and remove config from RenderBase.
The "q" prefix was a historical artifact. Rename the private subpackage to the simpler _renderer name, updating all 138 references across source, tests, and configuration.
The renderer has no style-specific logic, making BuilderPkgdown, BuilderSinglePage, and the _registry/__init_subclass__ dispatch mechanism redundant.
has2k1
force-pushed
the
remove-builder-style
branch
from
bf2e5d8 to
81b24dd
Compare
Previous commit undid a bundling of these errors but left the test unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renderer has no style-specific logic, making BuilderPkgdown,
BuilderSinglePage, and the _registry/init_subclass dispatch
mechanism redundant.
Depends on #81