Add support for Deepseek v4 flash - #88
Merged
Merged
Conversation
simonpcouch
commented
Aug 26, 2026
Comment on lines
+55
to
+56
| maxContextLength: 250_000, | ||
| maxInputTokens: 250_000, |
Collaborator
Author
There was a problem hiding this comment.
This is smaller than the 'real' context length, but artificially bringing this down to help us stay under rate limits.
Collaborator
Author
|
The failing test seems to be unrelated, so requesting review! |
wch
reviewed
Aug 26, 2026
Comment on lines
+121
to
+128
|
|
||
| const deepSeek = inferModelCapabilities("positai", "deepseek-ai/DeepSeek-V4-Flash-0731"); | ||
| expect(deepSeek.family).toBe("deepseek-v4"); | ||
| expect(deepSeek.thinkingEffortLevels).toEqual(["off", "low", "high", "max"]); | ||
| expect(deepSeek.supportsImages).toBe(false); | ||
| expect(deepSeek.maxContextLength).toBe(250_000); | ||
| expect(deepSeek.maxInputTokens).toBe(250_000); | ||
| expect(deepSeek.maxOutputTokens).toBe(384_000); |
Collaborator
There was a problem hiding this comment.
These are the kinds of tests I've been trying to convince the AI to get rid of! Where it just tests some hard coded values.
Collaborator
Author
There was a problem hiding this comment.
So true, been meaning to do this in commons. You got it.
wch
approved these changes
Aug 26, 2026
wch
left a comment
wch
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - I just had a comment on some extraneous tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1/5 to introduce support for Deepseek v4 Flash in Posit AI.
The model requires
reasoning_effort: "none"to explicitly disable thinking, while the generic helper omits thinking fields foroff.positAiThinkingRequestFields()contains this model-specific exception.