Rename connect provider to posit-connect, export integrations read - #85
Merged
Conversation
…t read Promote the private fetchIntegrationRecords into an exported helper that fetches, validates, and shapes allowlisted integrations, so host test probes (e.g. Posit Assistant's provider:test) share the endpoint path, auth convention, and response validation with discovery instead of re-implementing them. HTTP errors now include the status text.
The bare `connect` id collides conceptually with Positron's generic "connect a provider" UI vocabulary; `posit-connect` names the product unambiguously. Renames the provider id / client kind / schema key / env-mapping keys and the minted model-id prefix (now `posit-connect-<slug>-<guid>/<modelId>`). The provider is experimental and unreleased, so there are no stored credentials or stamped model ids to migrate. Env vars stay CONNECT_API_KEY and POSIT_CONNECT_URL.
Add regression coverage for both canonical env dispatch keys under the renamed provider id: CONNECT_API_KEY through the ai-credentials env credential resolver, and POSIT_CONNECT_URL through ai-config's connection-env layer into the resolved catalog. Also update the SUPPORTED_CUSTOM_CLIENT_KIND_VALUES doc comment, which still named the pre-rename `connect` kind.
ssinnott
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems with the built-in Connect provider that shipped in #81. First, its provider id
connectcollides with the generic "connect a provider" vocabulary in host UIs (notably Positron), so logs, schema keys, and model ids read ambiguously. Second, a host application that wants to validate a Connect configuration — for example Posit Assistant's Test button in the AI Providers dialog — had to re-implement the integrations-endpoint read (path,Authorization: Keyconvention, response validation), duplicating logic that must stay in sync with discovery.This PR renames the provider id, client kind, schema key, env-mapping keys, and the minted model-id prefix from
connecttoposit-connect, so the product is named unambiguously everywhere (models now appear asposit-connect-<slug>-<guid>/<modelId>). It also promotes the private integrations fetch into an exportedfetchConnectIntegrationshelper that fetches, validates, and shapes allowlisted integrations, so discovery and host test probes share one canonical read of the endpoint instead of drifting apart. Regression tests now cover both env dispatch keys under the renamed id:CONNECT_API_KEYthrough the ai-credentials env resolver andPOSIT_CONNECT_URLthrough ai-config's connection-env layer into the resolved catalog.Compatibility is preserved where it matters: the provider is experimental and unreleased, so there are no stored credentials or stamped model ids to migrate, and the environment variable names stay
CONNECT_API_KEYandPOSIT_CONNECT_URL. Error reporting improves slightly — HTTP failures from the integrations endpoint now include the status text — and unsupported integration templates continue to be skipped with a warning rather than failing discovery.Verification
connect-provider.test.tscovers the rename (minted prefixes, log tags) and the exported helper's validation and shaping.CONNECT_API_KEYresolves through the env credential resolver andPOSIT_CONNECT_URLflows into the resolved catalog under theposit-connectid.