AKS cloud support for asyncdr #2737
Conversation
gejain
force-pushed
the
akstest
branch
3 times, most recently
from
dd1b44b
to
cd02470
Compare
| pxStc.Spec.Metadata.Annotations[pxStcServiceKey][awsInternalLBKey] = awsInternalLBValue | ||
| pxStc.Spec.Metadata.Annotations[pxStcServiceKey][awsLBTypeKey] = awsLBTypeVal | ||
| pxStc.Spec.Metadata.Annotations[pxStcServiceKey][awsNLBTargetTypeKey] = awsNLBTargetTypeVal | ||
| pxStc.Spec.Metadata.Annotations[pxStcServiceKey][awsLBSubnetKey] = os.Getenv("LB_SUBNET_KEY") |
There was a problem hiding this comment.
How about we add a check to see if LB_SUBNET_KEY is empty?
| log.FailOnError(err, "failed to change PX service to LoadBalancer on source cluster") | ||
| } | ||
| if cloudName == "eks" { | ||
| pxService, err := core.Instance().GetService("portworx-service", "kube-system") |
There was a problem hiding this comment.
Is it "kube-system" or portworx namespace?
| @@ -95,6 +95,9 @@ RUN apk add --no-cache openssh sshpass | |||
| # Install dependancy for OCP 4.14 CLI | |||
| RUN apk --update add gcompat | |||
|
|
|||
| #Install aws-cli | |||
| RUN apk add aws-cli && aws --version | |||
There was a problem hiding this comment.
what is this cli used for?
There was a problem hiding this comment.
Its needed for EKS cluster switch from torepedo. We need to access source and destination.
Without this we get below error -
failed to switch to context. RefreshNodeRegistry Error
pkg/asyncdr/asyncdr.go
Outdated
| log.Infof("Storage driver name: %v", storageDriverName) | ||
|
|
||
| if storageDriverName == storkdriver.PortworxDriverName { | ||
| stc, err := operator.Instance().ListStorageClusters(pxNamespace) |
There was a problem hiding this comment.
Inst().V.GetDriver() will give you the STC
There was a problem hiding this comment.
you are still using operator.Instance()
There was a problem hiding this comment.
Sorry I missed this, just updated please check
pkg/asyncdr/asyncdr.go
Outdated
| log.Infof("Storage driver name: %v", storageDriverName) | ||
|
|
||
| if storageDriverName == storkdriver.PortworxDriverName { | ||
| stc, err := operator.Instance().ListStorageClusters(pxNamespace) |
There was a problem hiding this comment.
you are still using operator.Instance()
I added changes, Thanks! |
PTX-25618 - AKS cloud support for asyncdr
What this PR does / why we need it:
We can run asyncdr on cloud
Which issue(s) this PR fixes (optional)
Closes # https://purestorage.atlassian.net/browse/PTX-25618
Special notes for your reviewer:
Passed Job -
https://jenkins.pwx.dev.purestorage.com/job/Users/job/Geet/job/stork-systemtest-aks/8/