Rename bitmaps into bmp, to prevent misleading #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zxkmm
commented
Dec 31, 2024
•
zxkmm
commented
- rename bitmaps folder into bmps (it's a mistake from someone who made it), bmp isn't bitmap
- In short, on portapack's graphic thing, only splash/sstv/warning modal using bmp, others is using bitmap, the two files is bmp instead of bitmap
zxkmm
force-pushed
the
bitmap_and_bmp_tune
branch
from
6356d74 to
4c18b80
Compare
zxkmm
changed the title
auto-merge was automatically disabled
January 1, 2025 12:39
Pull request was converted to draft
|
I originally wanted this to be have one go with the key copier app, but after talking with community, i believe adding that app is useless. So this PR would be ready as is. |
gullradriel
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.