Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch to paging the button grid (AKA home menu tiles) #2453

Closed
wants to merge 1 commit into from

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Dec 29, 2024

Previously I implemented a up and down button to paging the button grid, but was rejected by community due to it was ugly

This PR doesn't change the visual thing, but you can paging by touch the gap on the bottom of the screen

We have more and more app now. I make this design is because it doesn't make sense to need an encoder to enter some of the app. it should be done by touchscreen.


test fw: https://discord.com/channels/719669764804444213/722101917135798312/1322965133869453312

@zxkmm zxkmm marked this pull request as ready for review December 29, 2024 17:05
@gullradriel
Copy link
Member

How do you go up ?
Does it make sense to be able to page down, and not up?

@u-foka
Copy link
Contributor

u-foka commented Dec 29, 2024

I would suggest to make visible buttons both up and down.
Also make it optional similar to the menu back button so that who don't want to use it won't be bothered :)

@htotoo
Copy link
Member

htotoo commented Dec 29, 2024

And make it default off :)
Maybe we could make multiple launcher designs in the future, like the theming system

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

How do you go up ?

Does it make sense to be able to page down, and not up?

It can go rounding, currently the 2nd or 3rd press would be go back to offset = 0

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

I would suggest to make visible buttons both up and down.

Also make it optional similar to the menu back button so that who don't want to use it won't be bothered :)

Ya the visual up and down buttons were rejected by community due to its ugly.

@zxkmm zxkmm marked this pull request as draft December 30, 2024 00:12
@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

I think I can also add an option along with auto start, but I probably won't make it into p.mem because probably should save p.mem on bigger things

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

Just checked and it seems BtnGridView class doesn't have a member SettingsStore obj yet.
I'm worried that it's not worth for ram usage to add SettingsStore obj as member only for this option, so I probably would close this if you don't like.

@htotoo
Copy link
Member

htotoo commented Dec 30, 2024

I think it in its current state is ok.
Won't harm anyone, but who knows it, may use.

Till there is no other solution, it would be good.

@gullradriel
Copy link
Member

gullradriel commented Dec 30, 2024

I would still like a visual drawing in the bottom to indicate that it's going down if you press here.
Like '>' but turned down.
It's just two lines to add to the draw grid (there is already a little blinking arrow on the bottom right corner, can take the drawing from here)
And I would prefer to have two area, one for up, one for down.
For the pmem thing, we are still having room for a simple "enable bottom scroll buttons" checkbox state.
'UI' settings are a bit crampied, but I'm pretty sure we can make room for one more checkbox.

@htotoo
Copy link
Member

htotoo commented Dec 30, 2024

Why not clicking the flashing arrow does the scrolling?

@gullradriel
Copy link
Member

Why not clicking the flashing arrow does the scrolling?

Too little

@gullradriel
Copy link
Member

Not everyone use a stylet. I only use my fingers.

@gullradriel
Copy link
Member

But why not have two of them, centered, as big as possible, only display if we can scroll ?
We would remove the blinking one and do not need a menu setting in that case.

@gullradriel
Copy link
Member

gullradriel commented Dec 30, 2024

Anyway I'm not using the rotary encoder when I need to get down.
I press the needed direction button and keep the button pressed. Magic.

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

If we are go the config way then I can make it like the back buttons, just can enable tiles

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

Or the Windows style, something like QScrollBar but without scroll bar
image

@gullradriel
Copy link
Member

I would prefer something visible to click.
Something like this:
image
And instead of blinking, we show the arrow static, and only if we can scroll up or down (hide the right arrow)

@gullradriel
Copy link
Member

BTW I checkout your PR locally, I may try to do it myself as I have free time this afternoon X-D

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

I would prefer something visible to click. Something like this: image And instead of blinking, we show the arrow static, and only if we can scroll up or down (hide the right arrow)

ya um last time i did this and was rejected by community (users)

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

BTW I checkout your PR locally, I may try to do it myself as I have free time this afternoon X-D

Sure! I can do this also, but i probably would get another vote before I really do it

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 30, 2024

close as another idea is better

@zxkmm zxkmm closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants