feat: modify custom binding action and description after creation #1575
+125
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pop-os#1566) An initial quick and dirty attempt to allow the descriptions and actions of custom shortcuts to be edited after create. This needs some more work to behave properly with the keybind replace dialog. We hook into `ShowShortcut` and set `self.add_shortcut.active = true` to have the correct context drawer shown. The extra code in the other branch of `custom::Page::context_drawer` should also probably be removed.
…ions (pop-os#1566) Note that this commit renamed the `editing` field on `AddShortcut` to `capturing_key` and added a new field `editing_action` which is the index of the `ShortcutModel`. The logic under `ShortcutMessage::ShowShortcut` in `custom.rs` probably belongs in `AddShortcut::enable`.
…op-os#1566) Next up is deleting keybinds and fixing a bug where the updated keybinds aren't correctly stored when editing. Also need to change the context drawer title so it isn't add when modifying.
…os#1566) Seems to mostly work aside from not being able to delete bindings from a shortcut. Maybe we want to save immediately on every edit but that is a matter of discussion for the PR. I encountered an issue of not being able to use the bindings that are being created, but I checked the config file and things are definetly being saved properly so I assume it has to do with the older cosmic-comp version I'm running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a suggestion from #1566
Changes
add_keybinding_contextfor both creating by auto-filling from existing shortcut.add_keybinding_context(Removed padding around binding input rows to make it look better with extra delete button, could use some adjusting)2025-11-13.17-36-46.mp4