Skip to content

Conversation

@git-f0x
Copy link
Contributor

@git-f0x git-f0x commented Nov 12, 2025

Makes all popovers use the same styling, with hover highlights (matching those on the VPN page currently).

Also removes some unnecessary Vecs.

Makes all popovers use the same styling, with hover highlights.
@wash2 wash2 requested a review from a team November 12, 2025 21:38
@jacobgkau jacobgkau self-assigned this Nov 14, 2025
@jacobgkau
Copy link
Member

Pop-overs still have different padding than drop-downs, so there's still some inconsistency here. I want to make sure we know what direction we're going with this.

This is what the pop-over currently looks like on the VPN page:

Screenshot_2025-11-13_17-25-14

This is what it used to look like on the Bluetooth page:

Screenshot_2025-11-13_17-25-24

This is what it will now look like on the Bluetooth page:

Screenshot_2025-11-13_17-25-40

This is what drop-downs still look like:

Screenshot_2025-11-13_17-25-49

@pop-os/ux Is this the direction we want to make the change, or would it be better to make the VPN pop-over match what the others currently look like (which is more similar to the drop-downs)? This topic is very similar to what was being discussed in pop-os/libcosmic#1042 (comment) regarding drop-down styling across different components.

@git-f0x
Copy link
Contributor Author

git-f0x commented Nov 14, 2025

This was mainly because the popovers on the keyboard and region pages were quite different and didn't feel nice.
The popovers are now styled very similar to context or app menus.
Though I think some padding could potentially look a bit better in menus as well, since the highlights have rounded corners.
Alternatively, the highlights could be square, but clipped at the corners of the menu (but that doesn't work with the current iced version).

@kleenleen
Copy link

kleenleen commented Nov 14, 2025

imho, the best looking one is this look but with an added padding for the highlight:
(but not as huge as it's it's currently the case for cosmic-settings dropdowns, it's currently way too much:
Current situation: missing padding / way oversized padding.)

Screenshot_2025-11-14_10-06-37 Screenshot_2025-11-10_13-25-03

And when in cosmic-settings choosing for multiple option, the check icon should be on the left side rather than on the right, because it gives this icon a consistent position rather that varying randomly based on the length of the longest entry. ...And actually, it is already set on the left for icon based choices, so why even having this icon on the right side at all ?

Screenshot_2025-11-14_10-03-17 Screenshot_2025-11-14_10-11-09

The best way dropdown could ever look

  • Clean small padding for highlight
  • Always a left blank for icons (visual aid / checked icon)
  • shortcut help darker than menu entry text and slightly smaller (to help without make the UI heavier looking)
  • separators that help sorting content

This example is not perfect (text is slightly too big and separators look better when they don't go full across) but it illustrates the niceness of having a constant left space for potential aiding icons/checked icons.
Screenshot 2025-11-14 103345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants