kms/surface: Don't send screencopysuccess() until sync point is reached
#1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, |
|
I think this should be good to merge pending Smithay/smithay#1805. |
Drakulix
approved these changes
Aug 21, 2025
Adding anything else to this tuple is awkward; defining a simple struct makes this cleaner. This also adds a `sync` property, which will come in handy later. Containing simply the same-named argument that was passed to `submit_buffer`.
A little annoying to add a `loop_handle` argument to `render_output`, but generally straightforward.
Shouldn't really matter, but no need to check the fence after this. It would be good if shm screencopy didn't block here...
Yeah, that part could be easier with Vulkan, though synchronization is known to be one of the more challenging aspects of Vulkan, so it has it's own difficulties. Probably should be possible to improve this on GL too, but that can be done later. Rebased and updated for merged smithay changes , so this should be good now. |
Drakulix
approved these changes
Aug 21, 2025
This was referenced Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Smithay/smithay#1805 to get a sync point from the blit, and then waits on it in a calloop source without blocking the thread.
Like #1580, this should fix some screen capture synchronization issues, but without the overhead of a
glFinish.