protocols/workspace: Set ext workspace id for pinned workspace
#1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pop-os/xdg-desktop-portal-cosmic#179, pop-os/cosmic-workspaces-epoch#199, pop-os/cosmic-applets#982, and pop-os/cosmic-panel#411 should be all the necessary client fixes to avoid crashes with this. (Annoying I missed this event that was added since our earlier version of the protocol was forked; I wish there was a way to make non-exhaustive matching a warning....) |
The `id` is defined to be sent only once, on creation of the handle or later. And only for workspaces that are "likely to be stable across multiple sessions". Set we add an `id` initially for pinned workspaces, and add one when the workspace is pinned. The `id` is not supposed to be human readable, so we just use a random value.
|
Oh yeah. Now those have been merged for a while, and everything here seems to be working. |
Drakulix
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idis defined to be sent only once, on creation of the handle or later. And only for workspaces that are "likely to be stable across multiple sessions".Set we add an
idinitially for pinned workspaces, and add one when the workspace is pinned.The
idis not supposed to be human readable, so we just use a random value.I don't think we currently have any plans that would need this feature, but this will allow scripts to recognize that a pinned workspace is the same as a workspace from a previous session, and do things like move a certain application to that workspace.
We'll need to update clients with pop-os/cosmic-protocols#62 before merging this.