Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Upgrade to LLVM 16 #4570

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

WIP: Upgrade to LLVM 16 #4570

wants to merge 7 commits into from

Conversation

hovsater
Copy link

No description provided.

@hovsater hovsater changed the title Llvm 16 WIP: Upgrade to LLVM 16 Dec 11, 2024
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Dec 11, 2024
@SeanTAllen SeanTAllen added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Dec 11, 2024
@ponylang-main
Copy link
Contributor

Hi @hovsater,

The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4570.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen
Copy link
Member

can you rebase this against main when you have a chance?

@hovsater
Bump LLVM to 16.0.6
f05a3d1
@hovsater
Remove LLVMInitializeObjCARCOpts pass
8cf21fe 
This is no longer available in LLVM 16.

See also:

* https://reviews.llvm.org/D135041
@hovsater
Remove LLVMInitializeInstrumentation pass
1b8bff0 
This is no longer available in LLVM 16.

See also:

* https://reviews.llvm.org/D136615
@hovsater
Replace LLVMConstFNeg with LLVMBuildFNeg
f93abd9 
The function LLVMConstFNeg has been removed, because the underlying
constant expression in no longer supported. Instead, an instruction
should be created using the LLVMBuildFNeg function, which will constant
fold the operands if possible and create an instruction otherwise.

See also:

* https://releases.llvm.org/16.0.0/docs/ReleaseNotes.html#changes-to-the-c-api
@hovsater
LLVM 16 requires C++17 by default
99726e2
@hovsater
Migrate to memory effect attributes instead
cf83772 
See also:

* https://reviews.llvm.org/D135780#diff-change-PgNBt2hWftpZ
* https://discourse.llvm.org/t/rfc-unify-memory-effect-attributes/65579
@hovsater
Replace llvm::Optional/llvm:None with std variants
ef46092 
See also:

* https://reviews.llvm.org/D149128
* https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716
@hovsater
Copy link
Author

can you rebase this against main when you have a chance?

I've rebased with the latest changes from main now. I intend to continue my work here as soon as I get some spare time on my hands. We're getting ever so closer to the holidays. 🎅

@SeanTAllen SeanTAllen removed the discuss during sync Should be discussed during an upcoming sync label Dec 17, 2024
SeanTAllen
SeanTAllen reviewed Dec 17, 2024
View reviewed changes
src/libponyc/codegen/codegen.c
LLVMInitializeVectorization(passreg);
LLVMInitializeInstCombine(passreg);
LLVMInitializeIPO(passreg);
LLVMInitializeInstrumentation(passreg);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were these passes removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. See the commits. Every commit should have references and an explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanTAllen SeanTAllen SeanTAllen left review comments

Assignees
No one assigned
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hovsater @ponylang-main @SeanTAllen